[MediaWiki-commits] [Gerrit] Remove animation to speed up denser plots - change (analytics/dashiki)

[Milimetric (Code Review)]

Milimetric has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/175137

Change subject: Remove animation to speed up denser plots
......................................................................

Remove animation to speed up denser plots

Change-Id: I0d8e86d7eff193ce58c1836871841bb4b5ce297b
---
M src/components/visualizers/vega-timeseries/bindings.js
M src/components/visualizers/vega-timeseries/vega-timeseries.js
2 files changed, 13 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/dashiki 
refs/changes/37/175137/1

diff --git a/src/components/visualizers/vega-timeseries/bindings.js 
b/src/components/visualizers/vega-timeseries/bindings.js
index 8f627ab..fbc5983 100644
--- a/src/components/visualizers/vega-timeseries/bindings.js
+++ b/src/components/visualizers/vega-timeseries/bindings.js
@@ -32,12 +32,14 @@
         var unwrap = ko.unwrap(valueAccessor());
 
         // override defaults with any changed values
-        return setOrDefault(unwrap, {
+        var withDefaults = setOrDefault(unwrap, {
             data: [],
             width: 'auto',
             height: 'auto',
             parentSelector: '.parent-of-resizable',
-            updateDuration: 300,
+            updateOptions: {
+                duration: 300
+            },
             padding: {
                 top: 30,
                 right: 108,
@@ -47,6 +49,12 @@
             strokeWidth: 2,
             colorScale: undefined
         });
+
+        // don't animate if there's a ton of data
+        if (withDefaults.data.length >= 1000) {
+            withDefaults.updateOptions = null;
+        }
+        return withDefaults;
     }
 
     function processAutosize(value, element) {
@@ -233,9 +241,7 @@
                         element.view
                             .height(dimensions.height)
                             .width(dimensions.width)
-                            .update({
-                                duration: value.updateDuration
-                            });
+                            .update(value.updateOptions);
                     }
                 }
             });
@@ -267,9 +273,7 @@
 
             if (element.view) {
                 var parsed = vega.parse.data(vegaData(value.data)).load;
-                element.view.data(parsed).update({
-                    duration: value.updateDuration
-                });
+                element.view.data(parsed).update(value.updateOptions);
                 updateColor();
             } else {
                 vega.parse.spec(vegaDefinition(value), function (graph) {
diff --git a/src/components/visualizers/vega-timeseries/vega-timeseries.js 
b/src/components/visualizers/vega-timeseries/vega-timeseries.js
index 2978b01..d99ea8e 100644
--- a/src/components/visualizers/vega-timeseries/vega-timeseries.js
+++ b/src/components/visualizers/vega-timeseries/vega-timeseries.js
@@ -14,7 +14,7 @@
             width           : 'auto',
             height          : 'auto',
             parentSelector  : '.parent-of-resizable',
-            updateDuration  : 300,
+            updateOptions   : {duration: 300},
             padding         : {top: 30, right: 40, bottom: 30, left: 35},
             strokeWidth     : 2
             colorScale      : undefined (pass a ko.observable to monitor color)

-- 
To view, visit https://gerrit.wikimedia.org/r/175137
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d8e86d7eff193ce58c1836871841bb4b5ce297b
Gerrit-PatchSet: 1
Gerrit-Project: analytics/dashiki
Gerrit-Branch: master
Gerrit-Owner: Milimetric <dandree...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits