jenkins-bot has submitted this change and it was merged.
Change subject: Rename MovePageNotice to MovePageNoticeCreator
......................................................................
Rename MovePageNotice to MovePageNoticeCreator
More appropriate after Ia4aa9907f7d
Change-Id: I8e2d6a056131a65f89389e81c05cd1e68887786d
---
M client/WikibaseClient.hooks.php
R client/includes/hooks/MovePageNoticeCreator.php
R client/tests/phpunit/includes/hooks/MovePageNoticeCreatorTest.php
3 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
Aude: Looks good to me, approved
jenkins-bot: Verified
diff --git a/client/WikibaseClient.hooks.php b/client/WikibaseClient.hooks.php
index 9858fbb..58bda4c 100644
--- a/client/WikibaseClient.hooks.php
+++ b/client/WikibaseClient.hooks.php
@@ -33,7 +33,7 @@
use Wikibase\Client\Hooks\ChangesPageWikibaseFilterHandler;
use Wikibase\Client\Hooks\InfoActionHookHandler;
use Wikibase\Client\Hooks\SpecialWatchlistQueryHandler;
-use Wikibase\Client\MovePageNotice;
+use Wikibase\Client\MovePageNoticeCreator;
use Wikibase\Client\RecentChanges\ChangeLineFormatter;
use Wikibase\Client\RecentChanges\ExternalChangeFactory;
use Wikibase\Client\RecentChanges\RecentChangesFilterOptions;
@@ -184,7 +184,7 @@
$siteLinkLookup =
$wikibaseClient->getStore()->getSiteLinkTable();
$repoLinker = $wikibaseClient->newRepoLinker();
- $movePageNotice = new MovePageNotice(
+ $movePageNotice = new MovePageNoticeCreator(
$siteLinkLookup,
$wikibaseClient->getSettings()->getSetting(
'siteGlobalID' ),
$repoLinker
diff --git a/client/includes/hooks/MovePageNotice.php
b/client/includes/hooks/MovePageNoticeCreator.php
similarity index 94%
rename from client/includes/hooks/MovePageNotice.php
rename to client/includes/hooks/MovePageNoticeCreator.php
index 1c0de37..bb25234 100644
--- a/client/includes/hooks/MovePageNotice.php
+++ b/client/includes/hooks/MovePageNoticeCreator.php
@@ -8,15 +8,15 @@
use Wikibase\Lib\Store\SiteLinkLookup;
/**
- * Adds a notice about the Wikibase Item belonging to the current page
+ * Gets a notice about the Wikibase Item belonging to the current page
* after a move (in case there's one).
*
- * @since 0.4
+ * @since 0.5
*
* @licence GNU GPL v2+
* @author Marius Hoch < [email protected] >
*/
-final class MovePageNotice {
+class MovePageNoticeCreator {
/**
* @var SiteLinkLookup
diff --git a/client/tests/phpunit/includes/hooks/MovePageNoticeTest.php
b/client/tests/phpunit/includes/hooks/MovePageNoticeCreatorTest.php
similarity index 91%
rename from client/tests/phpunit/includes/hooks/MovePageNoticeTest.php
rename to client/tests/phpunit/includes/hooks/MovePageNoticeCreatorTest.php
index 61ba4d1..1a8c193 100644
--- a/client/tests/phpunit/includes/hooks/MovePageNoticeTest.php
+++ b/client/tests/phpunit/includes/hooks/MovePageNoticeCreatorTest.php
@@ -4,13 +4,13 @@
use Language;
use Title;
-use Wikibase\Client\MovePageNotice;
+use Wikibase\Client\MovePageNoticeCreator;
use Wikibase\Client\RepoLinker;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\DataModel\SiteLink;
/**
- * @covers Wikibase\Client\MovePageNotice
+ * @covers Wikibase\Client\MovePageNoticeCreator
*
* @group WikibaseClient
* @group Wikibase
@@ -19,7 +19,7 @@
* @licence GNU GPL v2+
* @author Katie Filbert < [email protected] >
*/
-class MovePageNoticeTest extends \MediaWikiTestCase {
+class MovePageNoticeCreatorTest extends \MediaWikiTestCase {
protected function setUp() {
parent::setUp();
@@ -56,7 +56,7 @@
->with( new SiteLink( 'dewiki', 'New Amsterdam' ) )
->will( $this->returnValue( new ItemId( 'Q4880' ) ) );
- $movePageNotice = new MovePageNotice(
+ $movePageNotice = new MovePageNoticeCreator(
$siteLinkLookup,
'dewiki',
$this->getRepoLinker()
--
To view, visit https://gerrit.wikimedia.org/r/174052
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e2d6a056131a65f89389e81c05cd1e68887786d
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
