Kaldari has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175644
Change subject: New WikiGrok campaigns UI (version B)
......................................................................
New WikiGrok campaigns UI (version B)
For WikiGrok version B, when there are no tags selected, the button
should say 'None of these'.
Also, tweaking question text to be more concise (now that button
makes it clear that you don't have to select any).
Also, making release text slightly smaller per Jared.
Change-Id: I2ca6c65b31afb6b6a8b0a60d0ffff7127dbc6adc
---
M javascripts/modules/wikigrok/WikiGrokDialogB.js
M less/modules/wikigrok/WikiGrokDialog.less
M templates/modules/wikigrok/WikiGrokDialogB.hogan
3 files changed, 9 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/44/175644/1
diff --git a/javascripts/modules/wikigrok/WikiGrokDialogB.js
b/javascripts/modules/wikigrok/WikiGrokDialogB.js
index 1638718..8182202 100644
--- a/javascripts/modules/wikigrok/WikiGrokDialogB.js
+++ b/javascripts/modules/wikigrok/WikiGrokDialogB.js
@@ -77,6 +77,12 @@
$tag = $( '<div
class="ui-tag-button mw-ui-button">' )
.on( 'click', function
() {
$( this
).toggleClass( 'mw-ui-progressive' );
+ // If there are
any tags active, make submit button say 'Next'
+ if ( self.$(
'.tags .ui-tag-button.mw-ui-progressive' ).length ) {
+ self.$(
'.footer .save' ).text( 'Next' );
+ } else {
+ self.$(
'.footer .save' ).text( 'None of these' );
+ }
} ).appendTo( self.$(
'.tags' ) );
// FIXME: Use a template for
this magic.
@@ -117,7 +123,7 @@
self.$( '.wg-notice' ).hide();
self.$( '.wg-buttons' ).hide();
self.$( '.spinner' ).show();
- self.$( '.wg-content' ).text( 'Select any tags that
correctly describe ' + options.title + ':' );
+ self.$( '.wg-content' ).text( 'Select tags that
correctly describe ' + options.title + ':' );
self.$( '.footer' ).show();
self._renderSuggestions( options.suggestions );
diff --git a/less/modules/wikigrok/WikiGrokDialog.less
b/less/modules/wikigrok/WikiGrokDialog.less
index a088ee5..c0226c7 100644
--- a/less/modules/wikigrok/WikiGrokDialog.less
+++ b/less/modules/wikigrok/WikiGrokDialog.less
@@ -92,6 +92,7 @@
.license {
display: inline-block;
margin-right: 4.5em;
+ font-size: 0.9em;
}
.spinner {
diff --git a/templates/modules/wikigrok/WikiGrokDialogB.hogan
b/templates/modules/wikigrok/WikiGrokDialogB.hogan
index b756029..1561df8 100644
--- a/templates/modules/wikigrok/WikiGrokDialogB.hogan
+++ b/templates/modules/wikigrok/WikiGrokDialogB.hogan
@@ -19,6 +19,6 @@
<div class="footer">
<span class="license">All submissions are <a
href="#/wikigrok/about">released freely</a>.</span>
- <button class="mw-ui-button mw-ui-constructive
save">Next</button>
+ <button class="mw-ui-button mw-ui-constructive save">None of
these</button>
</div>
</div>
--
To view, visit https://gerrit.wikimedia.org/r/175644
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ca6c65b31afb6b6a8b0a60d0ffff7127dbc6adc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
