Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175761
Change subject: Fix call on undefined in entityselector.js
......................................................................
Fix call on undefined in entityselector.js
The .label property is not necesarrily set. Calling .toLowerCase()
on undefined causes this to fail. The error is not horrible, as far
as I can see, so this does not need to be backported.
Change-Id: Ic47db34e6e94ce85949795a19655b371041862c2
---
M lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/61/175761/1
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
b/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
index 1b17f4c..fcf27d6 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
@@ -179,14 +179,14 @@
this.__searching = setTimeout( function() {
self.search( event )
.done( function( suggestions, requestTerm ) {
- if( suggestions.length === 0 ||
self.element.val() !== requestTerm ) {
+ if( !suggestions.length ||
self.element.val() !== requestTerm ) {
return;
}
+ var label = suggestions[0].label ||
suggestions[0].id;
- if(
- suggestions[0].label ===
requestTerm
+ if( label === requestTerm
|| !self.options.caseSensitive
- &&
suggestions[0].label.toLowerCase() === requestTerm.toLowerCase()
+ && label.toLowerCase()
=== requestTerm.toLowerCase()
) {
self._select( suggestions[0] );
}
--
To view, visit https://gerrit.wikimedia.org/r/175761
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic47db34e6e94ce85949795a19655b371041862c2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
