Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/175823
Change subject: Make stuff in CachingEntityRevisionLookup private ...................................................................... Make stuff in CachingEntityRevisionLookup private Change-Id: I4aa42518308c641b2d90c775c0c5c39afbdd01cb --- M lib/includes/store/CachingEntityRevisionLookup.php 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/23/175823/1 diff --git a/lib/includes/store/CachingEntityRevisionLookup.php b/lib/includes/store/CachingEntityRevisionLookup.php index cc512bf..968e403 100644 --- a/lib/includes/store/CachingEntityRevisionLookup.php +++ b/lib/includes/store/CachingEntityRevisionLookup.php @@ -19,31 +19,31 @@ /** * @var EntityRevisionLookup */ - protected $lookup; + private $lookup; /** * The cache to use for caching entities. * * @var BagOStuff */ - protected $cache; + private $cache; /** * @var int $cacheTimeout */ - protected $cacheTimeout; + private $cacheTimeout; /** * The key prefix to use when caching entities in memory. * * @var $cacheKeyPrefix */ - protected $cacheKeyPrefix; + private $cacheKeyPrefix; /** * @var bool $shouldVerifyRevision */ - protected $shouldVerifyRevision; + private $shouldVerifyRevision; /** * @param EntityRevisionLookup $entityRevisionLookup The lookup to use @@ -81,7 +81,7 @@ * * @return String */ - protected function getCacheKey( EntityId $entityId ) { + private function getCacheKey( EntityId $entityId ) { $cacheKey = $this->cacheKeyPrefix . ':' . $entityId->getSerialization(); return $cacheKey; -- To view, visit https://gerrit.wikimedia.org/r/175823 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4aa42518308c641b2d90c775c0c5c39afbdd01cb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits