Ejegg has submitted this change and it was merged. Change subject: Enable CentralNotice client banner choice everywhere ......................................................................
Enable CentralNotice client banner choice everywhere Change-Id: I20688b64c253fd6817284647edb4226b0b235062 --- M wmf-config/CommonSettings.php 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Ejegg: Looks good to me, approved diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php index 1b54efd..6e4d384 100644 --- a/wmf-config/CommonSettings.php +++ b/wmf-config/CommonSettings.php @@ -1464,12 +1464,7 @@ $wgCentralBannerRecorder = "//{$wmfHostnames['meta']}/wiki/Special:RecordImpression"; } - $wgCentralNoticeChooseBannerOnClient = false; - - if ( ( $lang === 'aa' && $site === 'wikibooks' ) || - ( $wgDBname === 'mediawikiwiki' || $wgDBname == 'testwiki' ) ) { - $wgCentralNoticeChooseBannerOnClient = true; - } + $wgCentralNoticeChooseBannerOnClient = true; // Allow only these domains to access CentralNotice data through the reporter $wgNoticeReporterDomains = 'https://donate.wikimedia.org'; -- To view, visit https://gerrit.wikimedia.org/r/175863 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20688b64c253fd6817284647edb4226b0b235062 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: AndyRussG <andrew.green...@gmail.com> Gerrit-Reviewer: Ejegg <eeggles...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits