Kaldari has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175888
Change subject: Fixing WikiGrokDebug code
......................................................................
Fixing WikiGrokDebug code
item needs to be overridden before if ( !item ) check, otherwise it's
pretty useless.
Change-Id: I64785bbc7ff11520ee91213cdf4368978b1eed48
---
M includes/Hooks.php
1 file changed, 5 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiGrok
refs/changes/88/175888/1
diff --git a/includes/Hooks.php b/includes/Hooks.php
index 5110979..5ebb989 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -20,6 +20,11 @@
$profileSection = new \ProfileSection( __METHOD__ );
$item = $parserOutput->getProperty( 'wikibase_item' );
+ $config = self::getConfig();
+ if ( $config->get( 'WikiGrokDebug' ) ) {
+ $item = $out->getRequest()->getText( 'wikidataid',
$item );
+ }
+
if ( !\MobileContext::singleton()->shouldDisplayMobileView()
|| $out->getUser()->isAnon()
|| !$item
@@ -28,14 +33,8 @@
}
try {
- $config = self::getConfig();
$campaigns = new QuestionPicker( $config );
$store = new QuestionStore();
-
- if ( $config->get( 'WikiGrokDebug' ) ) {
- $item = $out->getRequest()->getText(
'wikidataid', $item );
- }
-
$list =
self::filterCampaigns(
$store->load( $out->getTitle() ),
--
To view, visit https://gerrit.wikimedia.org/r/175888
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I64785bbc7ff11520ee91213cdf4368978b1eed48
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiGrok
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
