jenkins-bot has submitted this change and it was merged.
Change subject: ve.init.mw.trackSubscriber: Populate platform field with hack
......................................................................
ve.init.mw.trackSubscriber: Populate platform field with hack
Use the target used as a proxy for the platform.
Assuming all mobile target users are tablets for now.
Change-Id: I24610e6b6d472744dc1011385c8810a65e06decf
---
M modules/ve-mw/init/ve.init.mw.trackSubscriber.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
b/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
index c53d100..ac40ade 100644
--- a/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
+++ b/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
@@ -69,7 +69,7 @@
version: 1,
action: action,
editor: 'visualeditor',
- platform: 'desktop', // FIXME
+ platform: ve.init.target.static.name ===
'mobile' ? 'tablet' : 'desktop', // HACK
integration: ve.init.target &&
ve.init.target.constructor.static.integrationType || 'page',
'page.id': mw.config.get( 'wgArticleId' ),
'page.title': mw.config.get( 'wgPageName' ),
--
To view, visit https://gerrit.wikimedia.org/r/175912
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24610e6b6d472744dc1011385c8810a65e06decf
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
