jenkins-bot has submitted this change and it was merged.
Change subject: Revert "ve.init.mw.trackSubscriber: Populate platform field
with hack"
......................................................................
Revert "ve.init.mw.trackSubscriber: Populate platform field with hack"
Caused JS errors when invoked too early.
This reverts commit 35d38985439dddf54b5001d569e82c9d719e7c6a.
Change-Id: Ie7dd4ef8323a16bb694e6300a096ba53cf4a0a91
---
M modules/ve-mw/init/ve.init.mw.trackSubscriber.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
b/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
index ac40ade..c53d100 100644
--- a/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
+++ b/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
@@ -69,7 +69,7 @@
version: 1,
action: action,
editor: 'visualeditor',
- platform: ve.init.target.static.name ===
'mobile' ? 'tablet' : 'desktop', // HACK
+ platform: 'desktop', // FIXME
integration: ve.init.target &&
ve.init.target.constructor.static.integrationType || 'page',
'page.id': mw.config.get( 'wgArticleId' ),
'page.title': mw.config.get( 'wgPageName' ),
--
To view, visit https://gerrit.wikimedia.org/r/175922
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7dd4ef8323a16bb694e6300a096ba53cf4a0a91
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
