Mooeypoo has uploaded a new change for review. https://gerrit.wikimedia.org/r/176028
Change subject: Change event listener for caption surface in media dialog ...................................................................... Change event listener for caption surface in media dialog Make sure the dialog is listening to the correct event for when caption surface changes. Change-Id: I214947a440e4f78adf1541d8008599fe65ac8b2c --- M modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/28/176028/1 diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js index e6f9f46..09fa461 100644 --- a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js +++ b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js @@ -842,8 +842,8 @@ ); // Events - this.captionSurface.getSurface().getModel().connect( this, { - documentUpdate: this.checkChanged.bind( this ) + captionDocument.connect( this, { + transact: this.checkChanged.bind( this ) } ); }; -- To view, visit https://gerrit.wikimedia.org/r/176028 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I214947a440e4f78adf1541d8008599fe65ac8b2c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Mooeypoo <mor...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits