jenkins-bot has submitted this change and it was merged.
Change subject: Don't use the writer as part of the renderTempDir.
......................................................................
Don't use the writer as part of the renderTempDir.
This was an artifact of when we thought we could reuse the same collection
id for multiple different writers. But the writer is part of the collection
id hash now, so we don't need to distinguish their temp dirs.
Change-Id: Idb98db5849aa2e092698c6a772999fcb6b049141
---
M lib/threads/backend.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Arlolra: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/threads/backend.js b/lib/threads/backend.js
index 51a9203..b826616 100644
--- a/lib/threads/backend.js
+++ b/lib/threads/backend.js
@@ -218,7 +218,7 @@
.then( function() {
renderTempDir = path.join(
config.backend.temp_dir,
- jobDetails.collectionId + '.' +
jobDetails.writer
+ jobDetails.collectionId
);
return Promise.promisify( fs.mkdir, false, fs )(
renderTempDir ).
then(function() {
--
To view, visit https://gerrit.wikimedia.org/r/176010
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb98db5849aa2e092698c6a772999fcb6b049141
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection/OfflineContentGenerator
Gerrit-Branch: master
Gerrit-Owner: Cscott <[email protected]>
Gerrit-Reviewer: Arlolra <[email protected]>
Gerrit-Reviewer: GWicke <[email protected]>
Gerrit-Reviewer: Mark Bergsma <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
