Stan has uploaded a new change for review. https://gerrit.wikimedia.org/r/176257
Change subject: ignore cop because is part of module api ...................................................................... ignore cop because is part of module api Bug: T75898 Change-Id: I34edaca3a9a673b76190dbad09b43b9d53d33bf0 --- M .rubocop_todo.yml M lib/mediawiki_selenium/support/env.rb 2 files changed, 1 insertion(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium refs/changes/57/176257/1 diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 6208958..6f12914 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -5,10 +5,6 @@ # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 1 -Style/AccessorMethodName: - Enabled: false - # Offense count: 5 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. diff --git a/lib/mediawiki_selenium/support/env.rb b/lib/mediawiki_selenium/support/env.rb index 9f8baa4..56f7ddc 100644 --- a/lib/mediawiki_selenium/support/env.rb +++ b/lib/mediawiki_selenium/support/env.rb @@ -141,7 +141,7 @@ browser end -def set_cookie(_browser) +def set_cookie(_browser) # rubocop:disable Style/AccessorMethodName # implement this method in env.rb of the repository where it is needed end def test_name(scenario) -- To view, visit https://gerrit.wikimedia.org/r/176257 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I34edaca3a9a673b76190dbad09b43b9d53d33bf0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/selenium Gerrit-Branch: master Gerrit-Owner: Stan <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
