Stan has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176279
Change subject: use guard clause per rubocop
......................................................................
use guard clause per rubocop
Bug: T75898
Change-Id: I782716d40d3a484a188f412c978540410b7152fe
---
M .rubocop_todo.yml
M lib/mediawiki_selenium/warnings_formatter.rb
2 files changed, 10 insertions(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium
refs/changes/79/176279/1
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 3ae7f98..7465f21 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -10,11 +10,6 @@
Style/GlobalVars:
Enabled: false
-# Offense count: 2
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
- Enabled: false
-
# Offense count: 12
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
diff --git a/lib/mediawiki_selenium/warnings_formatter.rb
b/lib/mediawiki_selenium/warnings_formatter.rb
index 2b2b19d..c4fc1f2 100644
--- a/lib/mediawiki_selenium/warnings_formatter.rb
+++ b/lib/mediawiki_selenium/warnings_formatter.rb
@@ -11,23 +11,20 @@
end
def after_feature(feature)
- if feature.mw_warnings.any?
- feature.mw_warnings.each do |type, messages|
- messages.each { |msg| @io.puts format_string(msg, :pending) }
- @warning_counts[type] += messages.length
- end
-
- @io.puts
+ return unless feature.mw_warnings.any?
+ feature.mw_warnings.each do |type, messages|
+ messages.each { |msg| @io.puts format_string(msg, :pending) }
+ @warning_counts[type] += messages.length
end
+ @io.puts
end
def after_features(_features)
- if @warning_counts.any?
- @warning_counts.each do |type, count|
- message = "#{count} warning#{count > 1 ? 's' : ''}"
- message += " due to #{type}" unless type == :default
- @io.puts format_string(message, :pending)
- end
+ return unless @warning_counts.any?
+ @warning_counts.each do |type, count|
+ message = "#{count} warning#{count > 1 ? 's' : ''}"
+ message += " due to #{type}" unless type == :default
+ @io.puts format_string(message, :pending)
end
end
--
To view, visit https://gerrit.wikimedia.org/r/176279
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I782716d40d3a484a188f412c978540410b7152fe
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Stan <tris...@saticed.me.uk>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
