Jeroen De Dauw has submitted this change and it was merged.
Change subject: Also propagate moves/deletions from non-Wikibase enabled
namespaces
......................................................................
Also propagate moves/deletions from non-Wikibase enabled namespaces
Per discussion with Lydia: If we start with invalid data, but end up
with valid data there's no reason not to propagate the move. Same
goes for deletions.
Change-Id: I02ecfffa1c69b230171a89c44a7859ecba9eda3f
---
M client/includes/hooks/UpdateRepoHookHandlers.php
1 file changed, 1 insertion(+), 7 deletions(-)
Approvals:
Jeroen De Dauw: Looks good to me, approved
diff --git a/client/includes/hooks/UpdateRepoHookHandlers.php
b/client/includes/hooks/UpdateRepoHookHandlers.php
index 2ad721e..a1b2180 100644
--- a/client/includes/hooks/UpdateRepoHookHandlers.php
+++ b/client/includes/hooks/UpdateRepoHookHandlers.php
@@ -205,11 +205,6 @@
* @return bool
*/
private function doArticleDeleteComplete( Title $title, User $user ) {
- if ( !$this->isWikibaseEnabled( $title->getNamespace() ) ) {
- // shorten out
- return true;
- }
-
if ( $this->propagateChangesToRepo !== true ) {
return true;
}
@@ -249,8 +244,7 @@
* @return bool
*/
private function doTitleMoveComplete( Title $oldTitle, Title $newTitle,
User $user ) {
- if ( !$this->isWikibaseEnabled( $oldTitle->getNamespace() )
- && !$this->isWikibaseEnabled( $newTitle->getNamespace()
) ) {
+ if ( !$this->isWikibaseEnabled( $newTitle->getNamespace() ) ) {
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/176290
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02ecfffa1c69b230171a89c44a7859ecba9eda3f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <h...@online.de>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
