TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/176479
Change subject: (bug 39643) Allow "0" as the content of <syntaxhighlight> ...................................................................... (bug 39643) Allow "0" as the content of <syntaxhighlight> The empty() function considers "0" to be empty. Makes empty() useless for strings. (cherry picked from commit 8d8fb22ebb508950d122474ccbbf3b18ddba8409) Change-Id: If0e647e3be269edcb23748d246bc564483aff0d2 --- M geshi/geshi.php 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SyntaxHighlight_GeSHi refs/changes/79/176479/1 diff --git a/geshi/geshi.php b/geshi/geshi.php index 405ff16..145be2f 100644 --- a/geshi/geshi.php +++ b/geshi/geshi.php @@ -595,10 +595,10 @@ * @since 1.0.0 */ function GeSHi($source = '', $language = '', $path = '') { - if (!empty($source)) { + if ($source !== '') { $this->set_source($source); } - if (!empty($language)) { + if ($language !== '') { $this->set_language($language); } $this->set_language_path($path); -- To view, visit https://gerrit.wikimedia.org/r/176479 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If0e647e3be269edcb23748d246bc564483aff0d2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SyntaxHighlight_GeSHi Gerrit-Branch: master Gerrit-Owner: TheDJ <hartman.w...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits