Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176869
Change subject: Don't use Html methods in LinkBeginHookHandler
......................................................................
Don't use Html methods in LinkBeginHookHandler
these are unnecessary here, add a bit of overhead
and make html rendering somewhat slower.
the message params (user input) still get escaped.
Change-Id: I972031c3109203c0401f69d845063f5c984e7f0c
---
M repo/includes/Hook/LinkBeginHookHandler.php
1 file changed, 7 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/69/176869/1
diff --git a/repo/includes/Hook/LinkBeginHookHandler.php
b/repo/includes/Hook/LinkBeginHookHandler.php
index 48dab3f..6b511c0 100644
--- a/repo/includes/Hook/LinkBeginHookHandler.php
+++ b/repo/includes/Hook/LinkBeginHookHandler.php
@@ -203,27 +203,24 @@
/** @var Language $labelLang */
list( $labelText, $labelLang ) = $this->extractTextAndLanguage(
$labelData );
- $idHtml = Html::openElement( 'span', array( 'class' =>
'wb-itemlink-id' ) )
+ $idHtml = '<span class="wb-itemlink-id">'
. wfMessage(
'wikibase-itemlink-id-wrapper',
$title->getText()
)->inContentLanguage()->escaped()
- . Html::closeElement( 'span' );
+ . '</span>';
- $labelHtml = Html::openElement( 'span', array(
- 'class' => 'wb-itemlink-label',
- 'lang' => $labelLang->getHtmlCode(),
- 'dir' => $labelLang->getDir()
- ) )
+ $labelHtml = '<span class="wb-itemlink-label" lang="' .
$labelLang->getHtmlCode()
+ . '" dir="' . $labelLang->getDir() . '">'
. htmlspecialchars( $labelText )
- . Html::closeElement( 'span' );
+ . '</span>';
- return Html::openElement( 'span', array( 'class' =>
'wb-itemlink' ) )
+ return '<span class="wb-itemlink">'
. wfMessage( 'wikibase-itemlink' )->rawParams(
$labelHtml,
$idHtml
)->inContentLanguage()->escaped()
- . Html::closeElement( 'span' );
+ . '</span>';
}
private function getTitleAttribute( Title $title, $labelData,
$descriptionData ) {
--
To view, visit https://gerrit.wikimedia.org/r/176869
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I972031c3109203c0401f69d845063f5c984e7f0c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
