jenkins-bot has submitted this change and it was merged.
Change subject: Adding check for lessphp compiler to getLessCompiler()
......................................................................
Adding check for lessphp compiler to getLessCompiler()
Otherwise, PHP fatal errors will be thrown for anyone who installs
without it.
Change-Id: Ia027b7a829bbdae88b750c8119c546c846f3ae54
---
M includes/resourceloader/ResourceLoader.php
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/resourceloader/ResourceLoader.php
b/includes/resourceloader/ResourceLoader.php
index eecb936..2c54f69 100644
--- a/includes/resourceloader/ResourceLoader.php
+++ b/includes/resourceloader/ResourceLoader.php
@@ -1490,6 +1490,9 @@
// When called from the installer, it is possible that a
required PHP extension
// is missing (at least for now; see bug 47564). If this is the
case, throw an
// exception (caught by the installer) to prevent a fatal error
later on.
+ if ( !class_exists( 'lessc' ) ) {
+ throw new MWException( 'MediaWiki requires the lessphp
compiler' );
+ }
if ( !function_exists( 'ctype_digit' ) ) {
throw new MWException( 'lessc requires the Ctype
extension' );
}
--
To view, visit https://gerrit.wikimedia.org/r/176809
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia027b7a829bbdae88b750c8119c546c846f3ae54
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
