Awight has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177139
Change subject: Wait until the 'clean' task is complete
......................................................................
Wait until the 'clean' task is complete
I think it was possible for the clean task to delete new, in-progress build
outputs.
Also, notify the operator when we've gone into "watching for changes" mode.
Change-Id: Ia0a69042edd0687ec536b4fb83e27acfa4092528
---
M gulpfile.js
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/dash
refs/changes/39/177139/1
diff --git a/gulpfile.js b/gulpfile.js
index 47760ae..e334a46 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -60,7 +60,7 @@
});
// Discovers all AMD dependencies, concatenates together all required .js
files, minifies them
-gulp.task('js', function () {
+gulp.task('js', ['clean'], function () {
return rjs(requireJsOptimizerConfig)
.pipe(uglify({
preserveComments: 'some'
@@ -72,7 +72,7 @@
.pipe(gulp.dest('./dist/'));
});
-gulp.task('css', function () {
+gulp.task('css', ['clean'], function () {
return gulp.src(['src/bower_modules/bootstrap/dist/css/bootstrap.css',
'src/bower_modules/nouislider/src/jquery.nouislider.css',
'src/bower_modules/fontawesome/css/font-awesome.css',
@@ -87,11 +87,11 @@
});
/** Copies semantic fonts where the css expects them to be**/
-gulp.task('font', function () {
+gulp.task('font', ['clean'], function () {
return gulp.src(['src/bower_modules/lato/font/*{ttf,woff,eot,svg}'])
.pipe(gulp.dest('./dist/font/'));
});
-gulp.task('fonts', function () {
+gulp.task('fonts', ['clean'], function () {
return
gulp.src(['src/bower_modules/fontawesome/fonts/*{ttf,woff,eot,svg,otf}'])
.pipe(gulp.dest('./dist/fonts/'));
});
@@ -162,6 +162,8 @@
callback();
console.log('\nPlaced optimized files in ' + chalk.magenta('dist/\n'));
console.log('\nPlaced font files in ' + chalk.magenta('font/\n'));
+
+ console.log('\nWatching changes... You\'re free to kill off this task
now.');
});
function logWatcher(event) {
--
To view, visit https://gerrit.wikimedia.org/r/177139
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0a69042edd0687ec536b4fb83e27acfa4092528
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/dash
Gerrit-Branch: master
Gerrit-Owner: Awight <awi...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
