Henning Snater has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177541
Change subject: $.wikibase.entityselector: Factored out _termMatchesLabel()
......................................................................
$.wikibase.entityselector: Factored out _termMatchesLabel()
Change-Id: I92506c84238392c28b8f3109b88471ec718cbd8a
---
M lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
1 file changed, 15 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/41/177541/1
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
b/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
index 382b96e..99ac7fd 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
@@ -186,11 +186,7 @@
return;
}
- var label = suggestions[0].label ||
suggestions[0].id;
- if( label === requestTerm
- || !self.options.caseSensitive
- && label.toLowerCase() ===
requestTerm.toLowerCase()
- ) {
+ if( self._termMatchesLabel( requestTerm,
suggestions[0] ) ) {
self._select( suggestions[0] );
}
} );
@@ -198,6 +194,20 @@
},
/**
+ * Determines whether a term matches a label considering the
`caseSensitive` option.
+ * @protected
+ *
+ * @param {string} term
+ * @param {Object} suggestion
+ * @return {boolean}
+ */
+ _termMatchesLabel: function( term, suggestion ) {
+ var label = suggestion.label || suggestion.id;
+ return label === term
+ || !this.options.caseSensitive && label.toLowerCase()
=== term.toLowerCase();
+ },
+
+ /**
* Create and return the data object for the api call.
* @protected
*
--
To view, visit https://gerrit.wikimedia.org/r/177541
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I92506c84238392c28b8f3109b88471ec718cbd8a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
