jenkins-bot has submitted this change and it was merged.

Change subject: Disable gadgets caching
......................................................................


Disable gadgets caching

Re-parsing of config page takes approximately the same time as deserialization
from cache, however with caching you're just putting an extra load on memcached.

The bug that made this experiment fail last time has since been fixed by 
Legoktm.

Change-Id: I9c1f4f0e086637d0d6fa907a6a4a4b4fbf2ac053
---
M wmf-config/CommonSettings-labs.php
M wmf-config/CommonSettings.php
2 files changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Legoktm: Looks good to me, but someone else must approve
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wmf-config/CommonSettings-labs.php 
b/wmf-config/CommonSettings-labs.php
index 322ff18..00a02c8 100644
--- a/wmf-config/CommonSettings-labs.php
+++ b/wmf-config/CommonSettings-labs.php
@@ -212,9 +212,6 @@
        include( 
"$IP/extensions/FundraisingTranslateWorkflow/FundraisingTranslateWorkflow.php" 
);
 }
 
-// Experimental
-$wgGadgetsCaching = false;
-
 $wgAjaxEditStash = true;
 
 } # end safeguard
diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index f2990cd..3a71a9c 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -677,6 +677,7 @@
 
 if ( $wmgUseGadgets ) {
        include( "$IP/extensions/Gadgets/Gadgets.php" );
+       $wgGadgetsCaching = false;
 }
 
 if ( $wmgUseMwEmbedSupport ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/177600
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9c1f4f0e086637d0d6fa907a6a4a4b4fbf2ac053
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: MaxSem <maxsem.w...@gmail.com>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to