jenkins-bot has submitted this change and it was merged.
Change subject: QA: remove unused argument for do block
......................................................................
QA: remove unused argument for do block
Change-Id: Ib9ba6aa1804dc1f30f114e0744e80b8a6ba69d4b
---
M .rubocop_todo.yml
M tests/browser/features/step_definitions/common_steps.rb
2 files changed, 1 insertion(+), 6 deletions(-)
Approvals:
Zfilipin: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 31a63bf..303b7fa 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -13,10 +13,6 @@
Lint/ParenthesesAsGroupedExpression:
Enabled: false
-# Offense count: 1
-# Cop supports --auto-correct.
-Lint/UnusedBlockArgument:
- Enabled: false
# Offense count: 1
# Configuration parameters: CountComments.
@@ -27,7 +23,6 @@
# Configuration parameters: AllowURI, URISchemes.
Metrics/LineLength:
Max: 428
-
# Offense count: 13
Style/Documentation:
diff --git a/tests/browser/features/step_definitions/common_steps.rb
b/tests/browser/features/step_definitions/common_steps.rb
index c2a587d..22b7d39 100644
--- a/tests/browser/features/step_definitions/common_steps.rb
+++ b/tests/browser/features/step_definitions/common_steps.rb
@@ -12,7 +12,7 @@
on(SpecialUserLoginPage).login_with("Selenium_newuser",
ENV["MEDIAWIKI_PASSWORD"])
end
-Given(/^I am logged in as a user with a > (\d+) edit count$/) do |arg1|
+Given(/^I am logged in as a user with a > (\d+) edit count$/) do
step 'I am on the "Main Page" page'
step 'I click on "Log in" in the main navigation menu'
# FIXME: Guarantee that MEDIAWIKI_USER has an edit count of > 0
--
To view, visit https://gerrit.wikimedia.org/r/177835
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9ba6aa1804dc1f30f114e0744e80b8a6ba69d4b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Zfilipin <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
