jenkins-bot has submitted this change and it was merged.
Change subject: Workaround for a scrolling bug in IE8 on resize
......................................................................
Workaround for a scrolling bug in IE8 on resize
Bug: T63910
Change-Id: I6dacc1ed2f2fdf4ea615a477b711dc78667bae68
---
M modules/jquery.wikiEditor.js
1 file changed, 10 insertions(+), 1 deletion(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/jquery.wikiEditor.js b/modules/jquery.wikiEditor.js
index e5d34aa..55a55a8 100644
--- a/modules/jquery.wikiEditor.js
+++ b/modules/jquery.wikiEditor.js
@@ -219,6 +219,9 @@
return $( this );
}
+// Save browser profile for detailed tests.
+var profile = $.client.profile();
+
/* Initialization */
// The wikiEditor context is stored in the element's data, so when this
function gets called again we can pick up right
@@ -311,6 +314,11 @@
* Executes core event filters as well as event handlers
provided by modules.
*/
trigger: function ( name, event ) {
+ // Workaround for a scrolling bug in IE8 (bug 61908)
+ if ( profile.name === 'msie' && profile.versionNumber
=== 8 ) {
+ context.$textarea.css( 'width',
context.$textarea.parent().width() );
+ }
+
// Event is an optional argument, but from here on out,
at least the type field should be dependable
if ( typeof event === 'undefined' ) {
event = { 'type': 'custom' };
@@ -467,8 +475,9 @@
/**
* Workaround for a scrolling bug in IE8 (bug 61908)
*/
- if ( $.client.profile().name === 'msie' ) {
+ if ( profile.name === 'msie' && profile.versionNumber === 8 ) {
context.$textarea.css( 'height', context.$textarea.height() );
+ context.$textarea.css( 'width',
context.$textarea.parent().width() );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/115378
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6dacc1ed2f2fdf4ea615a477b711dc78667bae68
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <gerritpatchuploa...@gmail.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Fomafix
Gerrit-Reviewer: Gerrit Patch Uploader <gerritpatchuploa...@gmail.com>
Gerrit-Reviewer: Paladox <thomasmulhall...@yahoo.com>
Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
