Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177992
Change subject: build: Use String#slice instead of discouraged String#substr
......................................................................
build: Use String#slice instead of discouraged String#substr
Aside from the confusion and differences between substr() and
substring() and IE8 bugs with substr(), substr() was removed from
the spec as of ECMAScript 5. It's been standardised in the
optional Annex B section of ES5.
Change-Id: I221ef6ae6956ce20dd9bb74510500f747d04c3b1
---
M build/tasks/git-build.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/unicodejs refs/changes/92/177992/1
diff --git a/build/tasks/git-build.js b/build/tasks/git-build.js
index 6053b5c..7d34e06 100644
--- a/build/tasks/git-build.js
+++ b/build/tasks/git-build.js
@@ -13,7 +13,7 @@
done( false );
return;
}
- grunt.config.set( 'pkg.version', grunt.config(
'pkg.version' ) + '-pre (' + stout.substr( 0, 10 ) + ')' );
+ grunt.config.set( 'pkg.version', grunt.config(
'pkg.version' ) + '-pre (' + stout.slice( 0, 10 ) + ')' );
grunt.verbose.writeln( 'Added git HEAD to pgk.version'
);
done();
} );
--
To view, visit https://gerrit.wikimedia.org/r/177992
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I221ef6ae6956ce20dd9bb74510500f747d04c3b1
Gerrit-PatchSet: 1
Gerrit-Project: unicodejs
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
