Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177994
Change subject: build: Use String#slice instead of discouraged String#substr
......................................................................
build: Use String#slice instead of discouraged String#substr
Aside from the confusion and differences between substr() and
substring() and IE8 bugs with substr(), substr() was removed from
the spec as of ECMAScript 5. It's been standardised in the
optional Annex B section of ES5.
Change-Id: I221ef6ae6956ce20dd9bb74510500f747d04c3b1
---
M Gruntfile.js
M build/tasks/colorize-svg.js
M demos/demo.js
3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/94/177994/1
diff --git a/Gruntfile.js b/Gruntfile.js
index 3a6f04e..1d3f257 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -328,7 +328,7 @@
done( false );
return;
}
- grunt.config.set( 'pkg.version', grunt.config(
'pkg.version' ) + '-pre (' + stout.substr( 0, 10 ) + ')' );
+ grunt.config.set( 'pkg.version', grunt.config(
'pkg.version' ) + '-pre (' + stout.slice( 0, 10 ) + ')' );
grunt.verbose.writeln( 'Added git HEAD to pgk.version'
);
done();
} );
diff --git a/build/tasks/colorize-svg.js b/build/tasks/colorize-svg.js
index 46b61bf..0ac2f79 100644
--- a/build/tasks/colorize-svg.js
+++ b/build/tasks/colorize-svg.js
@@ -163,7 +163,7 @@
file = this.file,
name = this.name,
fileExtension = path.extname( file ),
- fileExtensionBase = fileExtension.substr( 1 ),
+ fileExtensionBase = fileExtension.slice( 1 ),
fileNameBase = path.basename( file, fileExtension ),
filePath = path.join( this.list.getPath(), file ),
variable = fileExtensionBase.toLowerCase() === 'svg',
diff --git a/demos/demo.js b/demos/demo.js
index 7349673..22b6e91 100644
--- a/demos/demo.js
+++ b/demos/demo.js
@@ -244,7 +244,7 @@
* @return {string[]} Factor values in URL order: page, theme, graphics,
direction
*/
OO.ui.Demo.prototype.getCurrentFactorValues = function () {
- return location.hash.substr( 1 ).split( '-' );
+ return location.hash.slice( 1 ).split( '-' );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/177994
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I221ef6ae6956ce20dd9bb74510500f747d04c3b1
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
