Nikerabbit has uploaded a new change for review. https://gerrit.wikimedia.org/r/178047
Change subject: Update references to bugzilla to phabricator ...................................................................... Update references to bugzilla to phabricator Change-Id: I653bffa866331d3cb15d03e0a1090514e04553f7 --- M Translate.MyLanguage.alias.php M Translate.php M TranslateUtils.php M api/ApiHardMessages.php M composer.json M ffs/MediaWikiComplexMessages.php M messagegroups/RecentAdditionsMessageGroup.php M resources/js/ext.translate.quickedit.js M resources/js/ext.translate.special.aggregategroups.js M tag/PageTranslationHooks.php M tag/SpecialPageTranslationDeletePage.php M tag/SpecialPageTranslationMovePage.php M tag/TPException.php M tag/TranslateMoveJob.php M tests/phpunit/TranslateSandboxTest.php M utils/MessageGroupCache.php 16 files changed, 17 insertions(+), 32 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/47/178047/1 diff --git a/Translate.MyLanguage.alias.php b/Translate.MyLanguage.alias.php index 71e1076..c767c95 100644 --- a/Translate.MyLanguage.alias.php +++ b/Translate.MyLanguage.alias.php @@ -4,7 +4,7 @@ * This is a backwards compatibility file that separates the translations * in the extension from the translations of the same page's name * in core MediaWiki. For more information see the following bug: - * https://bugzilla.wikimedia.org/show_bug.cgi?id=69461 + * https://phabricator.wikimedia.org/T71461 * * @file * @license GPL-2.0+ diff --git a/Translate.php b/Translate.php index 958603f..e38c4fa 100644 --- a/Translate.php +++ b/Translate.php @@ -66,7 +66,8 @@ // Backwards compatibility: // If Special:MyLanguage is not in core, load translations of its name // from the Translate extension's code. -// See https://bugzilla.wikimedia.org/69461 +// See https://phabricator.wikimedia.org/T71461 +// Can be removed when MW 1.23 is no longer supported if ( !isset( $GLOBALS['wgAutoloadLocalClasses']['SpecialMyLanguage'] ) ) { $GLOBALS['wgExtensionMessagesFiles']['TranslateMyLanguageAlias'] = "$dir/Translate.MyLanguage.alias.php"; diff --git a/TranslateUtils.php b/TranslateUtils.php index f2e10c9..09243a3 100644 --- a/TranslateUtils.php +++ b/TranslateUtils.php @@ -205,7 +205,7 @@ public static function getLanguageNames( /*string */$code ) { $languageNames = Language::fetchLanguageNames( $code ); - // Remove languages with deprecated codes (bug 35475) + // Remove languages with deprecated codes (bug T37475) global $wgDummyLanguageCodes; foreach ( array_keys( $wgDummyLanguageCodes ) as $dummyLanguageCode ) { diff --git a/api/ApiHardMessages.php b/api/ApiHardMessages.php index f37279c..b7b9613 100644 --- a/api/ApiHardMessages.php +++ b/api/ApiHardMessages.php @@ -40,7 +40,7 @@ $revision = Revision::newFromTitle( $baseTitle ); if ( !$revision ) { - // This can fail. See https://bugzilla.wikimedia.org/show_bug.cgi?id=43286 + // This can fail. See https://phabricator.wikimedia.org/T45286 $this->dieUsage( 'Invalid revision', 'invalidrevision' ); } diff --git a/composer.json b/composer.json index 282d9dd..0df5528 100644 --- a/composer.json +++ b/composer.json @@ -28,7 +28,7 @@ } ], "support": { - "issues": "https://bugzilla.wikimedia.org/";, + "issues": "https://phabricator.wikimedia.org/tag/mediawiki-extensions-translate/";, "irc": "irc://irc.freenode.net/mediawiki-i18n", "forum": "https://www.mediawiki.org/wiki/Extension_talk:Translate";, "wiki": "https://www.mediawiki.org/wiki/Extension:Translate"; diff --git a/ffs/MediaWikiComplexMessages.php b/ffs/MediaWikiComplexMessages.php index 3ea1d1d..3034b8e 100644 --- a/ffs/MediaWikiComplexMessages.php +++ b/ffs/MediaWikiComplexMessages.php @@ -384,7 +384,7 @@ function formatForSave( WebRequest $request ) { $text = ''; - // Do not replace spaces by underscores for magic words. See bug 46613 + // Do not replace spaces by underscores for magic words. See bug T48613 $replaceSpace = $request->getVal( 'module' ) !== 'magic'; foreach ( array_keys( $this->data ) as $group ) { diff --git a/messagegroups/RecentAdditionsMessageGroup.php b/messagegroups/RecentAdditionsMessageGroup.php index 96db992..6a6d6bb 100644 --- a/messagegroups/RecentAdditionsMessageGroup.php +++ b/messagegroups/RecentAdditionsMessageGroup.php @@ -51,7 +51,6 @@ * Filters out messages that should not be displayed here * as they are not displayed in other places. * - * @see https://bugzilla.wikimedia.org/43030 * @param MessageHandle $handle * @return boolean */ diff --git a/resources/js/ext.translate.quickedit.js b/resources/js/ext.translate.quickedit.js index bc58104..6035ee5 100644 --- a/resources/js/ext.translate.quickedit.js +++ b/resources/js/ext.translate.quickedit.js @@ -208,7 +208,7 @@ } ); $td .html( convertWhiteSpaceToHTML( text ) ) - .attr( 'dir', 'auto' ) // (bug 29233) hacky, but better than nothing + .attr( 'dir', 'auto' ) // (bug T31233) hacky, but better than nothing .removeClass( 'untranslated' ) .addClass( 'justtranslated' ); }; @@ -349,7 +349,7 @@ // Update the cell value with the new translation $this .html( convertWhiteSpaceToHTML( text ) ) - .attr( 'dir', 'auto' ) // (bug 29233) hacky, but better than nothing + .attr( 'dir', 'auto' ) // (bug T31233) hacky, but better than nothing .removeClass( 'untranslated' ) .addClass( 'justtranslated' ); }; diff --git a/resources/js/ext.translate.special.aggregategroups.js b/resources/js/ext.translate.special.aggregategroups.js index e4c1c64..11cd05a 100644 --- a/resources/js/ext.translate.special.aggregategroups.js +++ b/resources/js/ext.translate.special.aggregategroups.js @@ -232,7 +232,7 @@ aggregateGroupDesc = aggGroupNameInputDesc.val(); // Empty the fields. If they are not emptied, then when another group - // is added, the values will appear again. Bug 36296. + // is added, the values will appear again. aggGroupNameInputName.val( '' ); aggGroupNameInputDesc.val( '' ); diff --git a/tag/PageTranslationHooks.php b/tag/PageTranslationHooks.php index dce67e7..60db830 100644 --- a/tag/PageTranslationHooks.php +++ b/tag/PageTranslationHooks.php @@ -89,7 +89,7 @@ $out->addModules( 'ext.translate.pagetranslation.uls' ); } - // Per bug 61331 + // Per bug T63331 $type = $isSource ? 'source' : 'translation'; $out->addJsConfigVars( 'wgTranslatePageTranslation', $type ); } @@ -465,13 +465,6 @@ public static function updateTranstagOnNullRevisions( Revision $rev, $text, $flags ) { $title = $rev->getTitle(); - /* Title might be null when using replicated databases. - * Even in that case null revisions should have valid - * titles since e778bf8. See bug 32983. */ - if ( !$title ) { - return true; - } - $newRevId = $rev->getId(); $oldRevId = $rev->getParentId(); $newTextId = $rev->getTextId(); @@ -485,7 +478,7 @@ 'rev_page' => $rev->getPage(), 'rev_id' => $oldRevId, ); - // FIXME: optimize away this query. Bug 36588. + // FIXME: optimize away this query. Bug T38588. $oldTextId = $dbw->selectField( $table, $field, $conds, __METHOD__ ); if ( strval( $newTextId ) !== strval( $oldTextId ) ) { diff --git a/tag/SpecialPageTranslationDeletePage.php b/tag/SpecialPageTranslationDeletePage.php index f4ea6fd..87dbefd 100644 --- a/tag/SpecialPageTranslationDeletePage.php +++ b/tag/SpecialPageTranslationDeletePage.php @@ -55,7 +55,7 @@ public function execute( $par ) { $request = $this->getRequest(); - // Yes, the use of getVal() and getText() is wanted, see bug 20365 + // Yes, the use of getVal() and getText() is wanted, see bug T22365 $this->text = $request->getVal( 'wpTitle', $par ); $this->title = Title::newFromText( $this->text ); $this->reason = $request->getText( 'reason' ); diff --git a/tag/SpecialPageTranslationMovePage.php b/tag/SpecialPageTranslationMovePage.php index aeb3999..b8a77b3 100644 --- a/tag/SpecialPageTranslationMovePage.php +++ b/tag/SpecialPageTranslationMovePage.php @@ -75,7 +75,7 @@ $request = $this->getRequest(); $user = $this->getUser(); - // Yes, the use of getVal() and getText() is wanted, see bug 20365 + // Yes, the use of getVal() and getText() is wanted, see bug T22365 $this->oldText = $request->getVal( 'wpOldTitle', $request->getVal( 'target', $par ) ); $this->newText = $request->getText( 'wpNewTitle' ); diff --git a/tag/TPException.php b/tag/TPException.php index c08a1f5..d4a5cfc 100644 --- a/tag/TPException.php +++ b/tag/TPException.php @@ -22,7 +22,7 @@ */ public function __construct( array $msg ) { $this->msg = $msg; - // Using ->plain() instead of ->text() due to bug 56226 + // Using ->plain() instead of ->text() due to bug T58226 $wikitext = call_user_func_array( 'wfMessage', $msg )->plain(); parent::__construct( $wikitext ); } diff --git a/tag/TranslateMoveJob.php b/tag/TranslateMoveJob.php index 59bc47c..da3035b 100644 --- a/tag/TranslateMoveJob.php +++ b/tag/TranslateMoveJob.php @@ -44,7 +44,8 @@ function run() { // Unfortunately the global is needed until bug is fixed: - // https://bugzilla.wikimedia.org/show_bug.cgi?id=49086 + // https://phabricator.wikimedia.org/T51086 + // Once MW >= 1.24 is supported, can use MovePage class. global $wgUser; // Initialization diff --git a/tests/phpunit/TranslateSandboxTest.php b/tests/phpunit/TranslateSandboxTest.php index c8cdb9c..ddfe040 100644 --- a/tests/phpunit/TranslateSandboxTest.php +++ b/tests/phpunit/TranslateSandboxTest.php @@ -22,9 +22,6 @@ public function testAddUser() { $user = TranslateSandbox::addUser( 'Test user', 't...@blackhole.io', 'test password' ); $this->assertTrue( $user->isLoggedIn(), 'User exists' ); - - // Work around for https://bugzilla.wikimedia.org/46844 - $groups = array_unique( $user->getGroups() ); $this->assertSame( array( 'translate-sandboxed' ), $groups, 'User is in the sandboxed group' ); } diff --git a/utils/MessageGroupCache.php b/utils/MessageGroupCache.php index 7429847..4f5713f 100644 --- a/utils/MessageGroupCache.php +++ b/utils/MessageGroupCache.php @@ -80,12 +80,6 @@ $value = $this->open()->get( '#keys' ); $array = unserialize( $value ); - // Debugging for bug 69830 - if ( !is_array( $array ) ) { - $filename = $this->getCacheFileName(); - throw new MWException( "Unable to get keys from '$filename'" ); - } - return $array; } -- To view, visit https://gerrit.wikimedia.org/r/178047 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I653bffa866331d3cb15d03e0a1090514e04553f7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nikerabbit <niklas.laxst...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
