TheDJ has uploaded a new change for review.
https://gerrit.wikimedia.org/r/178178
Change subject: mediawiki.feedback: improve error handling
......................................................................
mediawiki.feedback: improve error handling
Some loose ends with the rewrite to promises, add some logging in case
of errors, so it's a bit easier to figure out why something was failing
Bug: T51636
Change-Id: I081c58378566baef273b76c1a25c3b2d8ba0e19e
---
M resources/src/mediawiki/mediawiki.feedback.js
1 file changed, 13 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/78/178178/1
diff --git a/resources/src/mediawiki/mediawiki.feedback.js
b/resources/src/mediawiki/mediawiki.feedback.js
index 6bcb87f..587f5b9 100644
--- a/resources/src/mediawiki/mediawiki.feedback.js
+++ b/resources/src/mediawiki/mediawiki.feedback.js
@@ -260,21 +260,22 @@
{ redirect: true }
)
.done( function ( result ) {
- if ( result.edit !== undefined ) {
- if ( result.edit.result === 'Success' )
{
- fb.displayThanks();
- } else {
- // unknown API result
- fb.displayError(
'feedback-error1' );
- }
+ if ( result.edit.result === 'Success' ) {
+ fb.displayThanks();
} else {
- // edit failed
- fb.displayError( 'feedback-error2' );
+ // unknown API result
+ fb.displayError( 'feedback-error1' );
}
} )
- .fail( function () {
- // ajax request failed
- fb.displayError( 'feedback-error3' );
+ .fail( function ( code, result ) {
+ if ( code === 'http' ) {
+ // ajax request failed
+ fb.displayError( 'feedback-error3' );
+ mw.log.warn( 'Feedback report failed
with HTTP error: ' + result.textStatus );
+ } else {
+ fb.displayError( 'feedback-error2' );
+ mw.log.warn( 'Feedback report failed
with API error: ' + code );
+ }
} );
},
--
To view, visit https://gerrit.wikimedia.org/r/178178
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I081c58378566baef273b76c1a25c3b2d8ba0e19e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: TheDJ <hartman.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
