Dbrant has uploaded a new change for review. https://gerrit.wikimedia.org/r/178190
Change subject: Fix sending of SuggestedPagesFunnel "shown" event ...................................................................... Fix sending of SuggestedPagesFunnel "shown" event I thought I removed that line, but it somehow came back (maybe during a rebase). Bug: T76933 Change-Id: I9498a366cc4eb7f5e1cb69c2361265d411e77447 --- M wikipedia/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/90/178190/1 diff --git a/wikipedia/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java b/wikipedia/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java index 0a34360..41675e3 100644 --- a/wikipedia/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java +++ b/wikipedia/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java @@ -248,8 +248,6 @@ // Descriptions are expendable } }); - - funnel.logSuggestionsShown(pageTitle, results.getPageTitles()); } private final class ReadMoreAdapter extends BaseAdapter { -- To view, visit https://gerrit.wikimedia.org/r/178190 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9498a366cc4eb7f5e1cb69c2361265d411e77447 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Dbrant <dbr...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits