jenkins-bot has submitted this change and it was merged. Change subject: Fix for broken thumbnails when the file width is in $wgThumbnailBucket ......................................................................
Fix for broken thumbnails when the file width is in $wgThumbnailBucket When the source file width equals a bucket width, File::getThumbnailBucket() suggests the use of a thumbnail of that size. A thumbnailing attempt with the same width as the original usually returns an error; File::generateBucketsIfNeeded() creates an empty temporary file to later overwrite with the thumbnail, and does not clean that file up on error. This empty file is then used as the intermediary thumbnail for everything in the top bucket. Bug: T77950 Change-Id: I8c2fdd9b51d227f34cac874ed2b16c87adc9315d --- M includes/filerepo/file/File.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Anomie: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/filerepo/file/File.php b/includes/filerepo/file/File.php index c82be50..ae6b659 100644 --- a/includes/filerepo/file/File.php +++ b/includes/filerepo/file/File.php @@ -492,7 +492,7 @@ sort( $sortedBuckets ); foreach ( $sortedBuckets as $bucket ) { - if ( $bucket > $imageWidth ) { + if ( $bucket >= $imageWidth ) { return false; } -- To view, visit https://gerrit.wikimedia.org/r/178529 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c2fdd9b51d227f34cac874ed2b16c87adc9315d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.25wmf10 Gerrit-Owner: Gilles <gdu...@wikimedia.org> Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org> Gerrit-Reviewer: Anomie <bjor...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits