jenkins-bot has submitted this change and it was merged.
Change subject: Documentation and QUnit coverage for LanguageOverlay
......................................................................
Documentation and QUnit coverage for LanguageOverlay
Change-Id: I2e13bf1338e5e4005cd63f6fa20ca13c548104b7
---
M javascripts/modules/languages/LanguageOverlay.js
A tests/qunit/modules/languages/test_LanguageOverlay.js
2 files changed, 40 insertions(+), 0 deletions(-)
Approvals:
Bmansurov: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/modules/languages/LanguageOverlay.js
b/javascripts/modules/languages/LanguageOverlay.js
index 1e7be80..aa6f814 100644
--- a/javascripts/modules/languages/LanguageOverlay.js
+++ b/javascripts/modules/languages/LanguageOverlay.js
@@ -24,6 +24,7 @@
content: mw.template.get( 'mobile.languages',
'LanguageOverlay.hogan' )
},
+ /** @inheritdoc */
initialize: function ( options ) {
if ( options.languages && options.languages.length ) {
options.header = mw.msg(
'mobile-frontend-language-header', options.languages.length );
@@ -35,6 +36,10 @@
Overlay.prototype.initialize.apply( this, arguments );
},
+ /**
+ * Filter the language list to only show languages that match
the current search term.
+ * @param {String} val of search term.
+ */
filterLists: function ( val ) {
var $items = this.$( '.page-list li' ),
$subheaders = this.$( 'h3' );
@@ -55,6 +60,7 @@
}
},
+ /** @inheritdoc */
postRender: function () {
var self = this;
Overlay.prototype.postRender.apply( this, arguments );
@@ -68,6 +74,7 @@
}
} );
+ // FIXME: Naming inconsistency. modules/languages/LanguageOverlay or
languages/LanguageOverlay ?
M.define( 'languages/LanguageOverlay', LanguageOverlay );
}( mw.mobileFrontend, jQuery ) );
diff --git a/tests/qunit/modules/languages/test_LanguageOverlay.js
b/tests/qunit/modules/languages/test_LanguageOverlay.js
new file mode 100644
index 0000000..27892bc
--- /dev/null
+++ b/tests/qunit/modules/languages/test_LanguageOverlay.js
@@ -0,0 +1,33 @@
+( function ( LanguageOverlay ) {
+ QUnit.module( 'MobileFrontend: LanguageOverlay' );
+
+ QUnit.test( 'filterLanguages', 1, function ( assert ) {
+ var overlay = new LanguageOverlay( {
+ languages: [
+ {
+ lang: 'en',
+ langname: 'English',
+ title: 'The dog',
+ url: 'wiki/Dog'
+ },
+ {
+ lang: 'fr',
+ langname: 'French',
+ title: 'Le chien',
+ url: 'wiki/chien'
+ },
+ {
+ lang: 'pt',
+ langname: 'Portuguese',
+ title: 'O cachorro',
+ url: 'wiki/cachorro'
+ }
+ ]
+ } );
+ // Needed so we can make use of :visible
+ overlay.show();
+ overlay.filterLists( 'Port' );
+ assert.strictEqual( overlay.$( 'ul li:visible' ).length, 1,
'Only one of the results should be visible.' );
+ overlay.hide();
+ } );
+} )( mw.mobileFrontend.require( 'languages/LanguageOverlay' ) );
--
To view, visit https://gerrit.wikimedia.org/r/179038
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e13bf1338e5e4005cd63f6fa20ca13c548104b7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
