jenkins-bot has submitted this change and it was merged.
Change subject: QA: adjust spacing in steps and feature
......................................................................
QA: adjust spacing in steps and feature
Interim commit before updating actual code
Change-Id: I08e10ab7a51d83185ab99b4c5c6466a695ed88d1
---
M tests/browser/features/step_definitions/upload_wizard_steps.rb
M tests/browser/features/upload_wizard.feature
2 files changed, 25 insertions(+), 3 deletions(-)
Approvals:
Cmcmahon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/step_definitions/upload_wizard_steps.rb
b/tests/browser/features/step_definitions/upload_wizard_steps.rb
index b5af6a6..17cba3d 100644
--- a/tests/browser/features/step_definitions/upload_wizard_steps.rb
+++ b/tests/browser/features/step_definitions/upload_wizard_steps.rb
@@ -24,41 +24,53 @@
When(/^click button Continue$/) do
on(UploadPage).continue_element.when_present(15).click
end
+
When(/^I click Next button$/) do
on(UploadWizardPage).next_element.when_present(15).click
end
+
When(/^I click Next button at Describe page$/) do
sleep 1 # todo # I can not figure out at the moment how to make this work
without using sleep
on(DescribePage).next_element.when_present(15).click
end
+
When(/^I click Next button at Learn page$/) do
on(LearnPage).next_element.when_present(15).click
on(LearnPage).wait_for_ajax
end
+
When(/^I click Next button at Release rights page$/) do
on(ReleaseRightsPage).next_element.when_present(15).click
end
+
When(/^I click This file is my own work$/) do
on(ReleaseRightsPage).select_my_own_work
end
+
When(/^I enter category$/) do
on(DescribePage).category = "Test"
end
+
When(/^I enter date created$/) do
on(DescribePage).date_created = "11/4/2014"
end
+
When(/^I enter description$/) do
on(DescribePage).description = "description"
end
+
When(/^I enter title$/) do
on(DescribePage).title = "Title #{Random.new.rand}"
end
+
When(/^I navigate to Upload Wizard$/) do
visit UploadWizardPage
end
+
When(/^thumbnail should be visible$/) do
on(ReleaseRightsPage).thumbnail_element.when_present.should be_visible
end
+
When(/^I click the Skip checkbox$/) do
on(LearnPage).check_tutorial_skip
end
@@ -66,34 +78,44 @@
Then(/^link to log in should appear$/) do
on(UploadWizardPage).logged_in_element.should be_visible
end
+
Then(/^(.+) checkbox should be there$/) do |_|
on(LearnPage).tutorial_skip_element.when_present.should be_visible
end
+
Then(/^the tutorial should not be visible$/) do
on(LearnPage).tutorial_element.should_not be_visible
end
+
Then(/^Describe page should open$/) do
@browser.url.should match /Special:UploadWizard/
end
+
Then(/^Learn page should appear$/) do
@browser.url.should match /Special:UploadWizard/
end
+
Then(/^Release rights page should open$/) do
@browser.url.should match /Special:UploadWizard/
end
+
Then(/^Select a media file to donate button should be there$/) do
sleep 1
on(UploadPage).select_file_element.when_present.should be_visible
end
+
Then(/^title text field should be there$/) do
on(DescribePage).title_element.when_present.should be_visible
end
+
Then(/^Upload more files button should be there$/) do
on(UsePage).upload_more_files_element.when_present.should be_visible
end
+
Then(/^Upload page should appear$/) do
@browser.url.should match /Special:UploadWizard/
end
+
Then(/^Use page should open$/) do
@browser.url.should match /Special:UploadWizard/
end
diff --git a/tests/browser/features/upload_wizard.feature
b/tests/browser/features/upload_wizard.feature
index 749dc8b..907f7c3 100644
--- a/tests/browser/features/upload_wizard.feature
+++ b/tests/browser/features/upload_wizard.feature
@@ -27,8 +27,8 @@
Scenario: Skip tutorial
When I click the Skip checkbox
- And I click Next button at Learn page
- And I navigate to Upload Wizard
+ And I click Next button at Learn page
+ And I navigate to Upload Wizard
Then the tutorial should not be visible
Scenario: Navigate to Upload page
@@ -63,6 +63,6 @@
And I enter date created
And I click Next button at Describe page
Then Use page should open
- And Upload more files button should be there
+ And Upload more files button should be there
--
To view, visit https://gerrit.wikimedia.org/r/179182
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08e10ab7a51d83185ab99b4c5c6466a695ed88d1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
