BearND has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179227
Change subject: Enable Lint
......................................................................
Enable Lint
Mark string files that never get translated to ignore missing translations.
Set MissingTranslation to warnings.
Change-Id: If3235273632b17118e0a2096caa79a6fd51fe6d9
---
M wikipedia/build.gradle
M wikipedia/res/values/credits.xml
M wikipedia/res/values/device_prop.xml
M wikipedia/res/values/languages_list.xml
M wikipedia/res/values/last_updated.xml
M wikipedia/res/values/preference_keys.xml
6 files changed, 6 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/27/179227/1
diff --git a/wikipedia/build.gradle b/wikipedia/build.gradle
index a4f3329..9cc0088 100644
--- a/wikipedia/build.gradle
+++ b/wikipedia/build.gradle
@@ -76,10 +76,7 @@
}
// while we still have lint errors; remove once those are fixed
lintOptions {
- checkReleaseBuilds false
- // Or, if you prefer, you can continue to check for errors in release
builds,
- // but continue the build even when errors are found:
- abortOnError false
+ warning 'MissingTranslation'
}
}
diff --git a/wikipedia/res/values/credits.xml b/wikipedia/res/values/credits.xml
index 91e02b1..15b75a5 100644
--- a/wikipedia/res/values/credits.xml
+++ b/wikipedia/res/values/credits.xml
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
-<resources>
+<resources xmlns:tools="http://schemas.android.com/tools";
tools:ignore="MissingTranslation">
<string name="contributors_list">Adam Baso, Amir E. Aharoni, Anirudh S,
Bernd Sitzmann, Brion Vibber, Dan Garry, Dmitry Brant, Kenan Wang, Maryana
Pinchuk, Max Semenik, Moiz Syed, Monte Hurd, Mun May Tee, Nicole Borrelli,
Niklas Laxström, Thomas PT, Tomasz Finc, Vibha Bamba, Yuvi Panda</string>
<string name="libraries_list"><a href="http://acra.ch";>ACRA</a>
<!-- https://raw.githubusercontent.com/ACRA/acra/master/LICENSE -->
diff --git a/wikipedia/res/values/device_prop.xml
b/wikipedia/res/values/device_prop.xml
index 22485b8..4453c92 100644
--- a/wikipedia/res/values/device_prop.xml
+++ b/wikipedia/res/values/device_prop.xml
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
-<resources>
+<resources xmlns:tools="http://schemas.android.com/tools";
tools:ignore="MissingTranslation">
<string name="device_type">Phone</string>
</resources>
\ No newline at end of file
diff --git a/wikipedia/res/values/languages_list.xml
b/wikipedia/res/values/languages_list.xml
index 4c7cb1c..8ee16e1 100644
--- a/wikipedia/res/values/languages_list.xml
+++ b/wikipedia/res/values/languages_list.xml
@@ -1,5 +1,5 @@
<?xml version='1.0' encoding='utf-8'?>
-<resources>
+<resources xmlns:tools="http://schemas.android.com/tools";
tools:ignore="MissingTranslation">
<string-array name="preference_language_keys">
<item>en</item>
<item>nl</item>
diff --git a/wikipedia/res/values/last_updated.xml
b/wikipedia/res/values/last_updated.xml
index f0438ee..7d8fc9f 100644
--- a/wikipedia/res/values/last_updated.xml
+++ b/wikipedia/res/values/last_updated.xml
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
-<resources>
+<resources xmlns:tools="http://schemas.android.com/tools";
tools:ignore="MissingTranslation">
<!-- timestamp of when the bundled styles were last updated in ISO 8601-->
<string name="bundled_styles_updated">2019-06-17T00:00:00Z</string>
</resources>
\ No newline at end of file
diff --git a/wikipedia/res/values/preference_keys.xml
b/wikipedia/res/values/preference_keys.xml
index bd71d3d..17cd48e 100644
--- a/wikipedia/res/values/preference_keys.xml
+++ b/wikipedia/res/values/preference_keys.xml
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
-<resources>
+<resources xmlns:tools="http://schemas.android.com/tools";
tools:ignore="MissingTranslation">
<string name="preference_key_language">content_language</string>
<string name="preference_cookie_domains">cookie_domains</string>
<string
name="preference_cookies_for_domain">cookies_for_domain_%1$s</string>
--
To view, visit https://gerrit.wikimedia.org/r/179227
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If3235273632b17118e0a2096caa79a6fd51fe6d9
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND <bsitzm...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
