[MediaWiki-commits] [Gerrit] Prevent double clicks on gc cc forms - change (mediawiki...DonationInterface)

[Ssmith (Code Review)]

Ssmith has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/179354

Change subject: Prevent double clicks on gc cc forms
......................................................................

Prevent double clicks on gc cc forms

Change-Id: Ica094ca2fa542cff4452ed0e13dd43a5ab9fb635
---
M globalcollect_gateway/forms/js/gc.cc.js
M globalcollect_gateway/forms/js/gc.js
2 files changed, 7 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/54/179354/1

diff --git a/globalcollect_gateway/forms/js/gc.cc.js 
b/globalcollect_gateway/forms/js/gc.cc.js
index 5f19108..1005a4c 100644
--- a/globalcollect_gateway/forms/js/gc.cc.js
+++ b/globalcollect_gateway/forms/js/gc.cc.js
@@ -55,10 +55,14 @@
        } );
 
        // Set the cards to progress to step 3
-       $( '.cardradio' ).live( 'click', function () {
+       $( '.cardradio' ).live( 'change', function (event) {
+
+               $('.cardradio').prop('disabled', true);
+
                if ( validate_personal( document.payment ) && validateAmount() 
) {
                        $( '#payment' ).animate( { height: '314px' }, 1000 );
                        displayCreditCardForm();
+
                        // hide the continue button so that people don't get 
confused with two of them
                        $( '#paymentContinue' ).hide();
                } else {
diff --git a/globalcollect_gateway/forms/js/gc.js 
b/globalcollect_gateway/forms/js/gc.js
index 26f6237..f2e17d8 100644
--- a/globalcollect_gateway/forms/js/gc.js
+++ b/globalcollect_gateway/forms/js/gc.js
@@ -82,9 +82,11 @@
                                        mw.generatePaymentForm( data );
                                }
                        }
+                       $('.cardradio').prop('disabled', false);
                },
                error: function ( xhr ) {
                        alert( mw.msg( 'donate_interface-error-msg-general' ) );
+                       $('.cardradio').prop('disabled', false);
                }
        } );
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/179354
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica094ca2fa542cff4452ed0e13dd43a5ab9fb635
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ssmith <ssm...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits