Stan has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179464
Change subject: use &: style instead of block (per rubocop)
......................................................................
use &: style instead of block (per rubocop)
Bug: T75898
Change-Id: I1c3b45d093a0707e43c2bc0278934661921bb165
---
M .rubocop.yml
D .rubocop_todo.yml
M lib/mediawiki_selenium/environment.rb
3 files changed, 1 insertion(+), 16 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium
refs/changes/64/179464/1
diff --git a/.rubocop.yml b/.rubocop.yml
index 44f44f7..fdb5004 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,5 +1,3 @@
-inherit_from: .rubocop_todo.yml
-
Metrics/ClassLength:
Enabled: false
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
deleted file mode 100644
index 8c0c5b5..0000000
--- a/.rubocop_todo.yml
+++ /dev/null
@@ -1,13 +0,0 @@
-# This configuration was generated by `rubocop --auto-gen-config`
-# on 2014-12-09 15:44:54 +0000 using RuboCop version 0.26.1.
-# The point is for the user to remove these configuration records
-# one by one as the offenses are removed from the code base.
-# Note that changes in the inspected code, or installation of new
-# versions of RuboCop, may require this file to be generated again.
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: IgnoredMethods.
-Style/SymbolProc:
- Enabled: false
-
diff --git a/lib/mediawiki_selenium/environment.rb
b/lib/mediawiki_selenium/environment.rb
index ea75404..ff2e60a 100644
--- a/lib/mediawiki_selenium/environment.rb
+++ b/lib/mediawiki_selenium/environment.rb
@@ -257,7 +257,7 @@
#
def teardown(status = :passed)
@factory_cache.each do |_, factory|
- factory.each { |browser| browser.close } unless keep_browser_open?
+ factory.each(&:close) unless keep_browser_open?
factory.teardown(self, status)
end
end
--
To view, visit https://gerrit.wikimedia.org/r/179464
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c3b45d093a0707e43c2bc0278934661921bb165
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Stan <tris...@saticed.me.uk>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
