Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/179519

Change subject: Add more context to globaltitlefail logs
......................................................................

Add more context to globaltitlefail logs

Currently stuff like:
 MessageCache::parse called by 
Message::toString/Message::parseText/MessageCache::parse with no title set.

is showing up in the logs, and is totally useless.

Change-Id: I0ac3ca906c5a67e19974e3434d0e929e6b27fbb2
---
M includes/context/RequestContext.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/19/179519/1

diff --git a/includes/context/RequestContext.php 
b/includes/context/RequestContext.php
index 2a610a3..fe17fde 100644
--- a/includes/context/RequestContext.php
+++ b/includes/context/RequestContext.php
@@ -140,7 +140,7 @@
                if ( $this->title === null ) {
                        global $wgTitle; # fallback to $wg till we can improve 
this
                        $this->title = $wgTitle;
-                       wfDebugLog( 'GlobalTitleFail', __METHOD__ . ' called by 
' . wfGetAllCallers() . ' with no title set.' );
+                       wfDebugLog( 'GlobalTitleFail', __METHOD__ . ' called by 
' . wfGetAllCallers( 5 ) . ' with no title set.' );
                }
 
                return $this->title;

-- 
To view, visit https://gerrit.wikimedia.org/r/179519
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ac3ca906c5a67e19974e3434d0e929e6b27fbb2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to