Chad has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179525
Change subject: Don't set review flag if it wasn't in the query parameters
......................................................................
Don't set review flag if it wasn't in the query parameters
Change-Id: I7ea5d458a72083513c9c27f50d459122dba9cae3
---
M api/actions/ApiReview.php
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs
refs/changes/25/179525/1
diff --git a/api/actions/ApiReview.php b/api/actions/ApiReview.php
index 7881632..f359ec3 100644
--- a/api/actions/ApiReview.php
+++ b/api/actions/ApiReview.php
@@ -63,7 +63,9 @@
// The flagging parameters have the form 'flag_$name'.
// Extract them and put the values into $form->dims
foreach ( FlaggedRevs::getTags() as $tag ) {
- $form->setDim( $tag, (int)$params['flag_' . $tag] );
+ if ( isset( $params['flag_' . $tag] ) ) {
+ $form->setDim( $tag, (int)$params['flag_' .
$tag] );
+ }
}
if ( $form->getAction() === 'approve' ) {
$article = new FlaggableWikiPage( $title );
--
To view, visit https://gerrit.wikimedia.org/r/179525
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ea5d458a72083513c9c27f50d459122dba9cae3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Chad <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
