Giuseppe Lavagetto has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179609
Change subject: hhvm: remove jemalloc profiling completely
......................................................................
hhvm: remove jemalloc profiling completely
Contrary to jemalloc's documentation, we are still seeing heap maps
being dumped in production and that causes both latency and occasional
puppet failures (due to our housekeeping job that should supposedly
disable those failing). So, comment out the MALLOC_CONF line in the
upstart script.
Change-Id: Ie99c8a43aab965aeaf5c6ef421c937275e78b6a8
---
M modules/hhvm/files/hhvm.conf
M modules/mediawiki/manifests/hhvm.pp
2 files changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/09/179609/1
diff --git a/modules/hhvm/files/hhvm.conf b/modules/hhvm/files/hhvm.conf
index 2299d50..aeed4de 100644
--- a/modules/hhvm/files/hhvm.conf
+++ b/modules/hhvm/files/hhvm.conf
@@ -22,12 +22,12 @@
( cd /usr/lib/x86_64-linux-gnu/hhvm/extensions; ln -Trsf "$API_VERSION"
current; )
end script
-# Start HHVM with memory profiling capabilities enabled but inactive.
+# Decomment this to start HHVM with memory profiling capabilities enabled but
inactive.
# Profiling can then be toggled on-the-fly by cURLing the /jemalloc-prof-*
# endpoints of the admin server. See the jemalloc(3) man page for details.
# You can override these options by assigning MALLOC_CONF a different value
# in /etc/default/hhvm.
-env MALLOC_CONF="prof:true,prof_active:false,prof_final:false"
+#env MALLOC_CONF="prof:true,prof_active:false,prof_final:false"
script
. /etc/default/hhvm
diff --git a/modules/mediawiki/manifests/hhvm.pp
b/modules/mediawiki/manifests/hhvm.pp
index 5b17ad6..8a5a6ae 100644
--- a/modules/mediawiki/manifests/hhvm.pp
+++ b/modules/mediawiki/manifests/hhvm.pp
@@ -10,7 +10,6 @@
include ::hhvm::debug
include ::mediawiki::users
- include ::mediawiki::hhvm::housekeeping
# Derive HHVM's thread count by taking the smallest of:
# - the memory of the system divided by a typical thread memory allocation
--
To view, visit https://gerrit.wikimedia.org/r/179609
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie99c8a43aab965aeaf5c6ef421c937275e78b6a8
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Giuseppe Lavagetto <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
