Florianschmidtwelzow has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179632
Change subject: Add css class to donate button
......................................................................
Add css class to donate button
Don't give a php notice when class is not set in
MinervaTemplate::renderSecondaryActions().
Bug: T78480
Change-Id: Ib5f3a6e07e6c633cfa6aa631f95ff4a4a1cadb2c
---
M includes/skins/MinervaTemplate.php
M includes/skins/MinervaTemplateBeta.php
2 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/32/179632/1
diff --git a/includes/skins/MinervaTemplate.php
b/includes/skins/MinervaTemplate.php
index 83b5950..3c90ad9 100644
--- a/includes/skins/MinervaTemplate.php
+++ b/includes/skins/MinervaTemplate.php
@@ -208,8 +208,9 @@
echo Html::openElement( 'div', array( 'id' =>
'page-secondary-actions' ) );
foreach ( $this->getSecondaryActions() as $el ) {
+ $additionalClass = ( isset( $el['class'] ) ?
$el['class'] : '' );
echo Html::element( 'a', array(
- 'class' => 'mw-ui-button button ' .
$el['class'],
+ 'class' => 'mw-ui-button button ' .
$additionalClass,
'href' => $el['url']
), $el['label'] );
}
diff --git a/includes/skins/MinervaTemplateBeta.php
b/includes/skins/MinervaTemplateBeta.php
index d0988df..5133178 100644
--- a/includes/skins/MinervaTemplateBeta.php
+++ b/includes/skins/MinervaTemplateBeta.php
@@ -33,6 +33,7 @@
if ( $wgMFDonationUrl ) {
$result['donation'] = array(
'url' => $wgMFDonationUrl,
+ 'class' => 'donate-button',
'label' => wfMessage(
'mobile-frontend-donate-button-label' )->text()
);
}
--
To view, visit https://gerrit.wikimedia.org/r/179632
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5f3a6e07e6c633cfa6aa631f95ff4a4a1cadb2c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
