Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/179950
Change subject: SpecialPage::execute doesn't return anything ...................................................................... SpecialPage::execute doesn't return anything Change-Id: I6f413a633b71739592aae8c8b2db61ad4abc2a79 --- M includes/specials/SpecialChangeEmail.php 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/50/179950/1 diff --git a/includes/specials/SpecialChangeEmail.php b/includes/specials/SpecialChangeEmail.php index 12bbd2a..4f278eb 100644 --- a/includes/specials/SpecialChangeEmail.php +++ b/includes/specials/SpecialChangeEmail.php @@ -39,7 +39,7 @@ /** * @return bool */ - function isListed() { + public function isListed() { global $wgAuth; return $wgAuth->allowPropChange( 'emailaddress' ); @@ -54,7 +54,7 @@ $out->disallowUserJs(); $out->addModules( 'mediawiki.special.changeemail' ); - return parent::execute( $par ); + parent::execute( $par ); } protected function checkExecutePermissions( User $user ) { @@ -149,7 +149,7 @@ * @param string $newaddr * @return Status */ - protected function attemptChange( User $user, $pass, $newaddr ) { + private function attemptChange( User $user, $pass, $newaddr ) { global $wgAuth; if ( $newaddr != '' && !Sanitizer::validateEmail( $newaddr ) ) { -- To view, visit https://gerrit.wikimedia.org/r/179950 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6f413a633b71739592aae8c8b2db61ad4abc2a79 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits