Adrian Lang has uploaded a new change for review.
https://gerrit.wikimedia.org/r/180154
Change subject: Remove DispatchingSnakFormatter usage from View
......................................................................
Remove DispatchingSnakFormatter usage from View
Change-Id: I2f81844112e2b0f72402628f8c432f2f38fc2881
---
M repo/tests/phpunit/includes/View/ClaimHtmlGeneratorTest.php
M repo/tests/phpunit/includes/View/SnakHtmlGeneratorTest.php
2 files changed, 4 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/54/180154/1
diff --git a/repo/tests/phpunit/includes/View/ClaimHtmlGeneratorTest.php
b/repo/tests/phpunit/includes/View/ClaimHtmlGeneratorTest.php
index 71664db..1371d9d 100644
--- a/repo/tests/phpunit/includes/View/ClaimHtmlGeneratorTest.php
+++ b/repo/tests/phpunit/includes/View/ClaimHtmlGeneratorTest.php
@@ -13,7 +13,6 @@
use Wikibase\DataModel\Snak\PropertyValueSnak;
use Wikibase\DataModel\Snak\SnakList;
use Wikibase\DataModel\Statement\Statement;
-use Wikibase\Lib\DispatchingSnakFormatter;
use Wikibase\Lib\EntityIdFormatter;
use Wikibase\Lib\SnakFormatter;
use Wikibase\Lib\Store\EntityTitleLookup;
@@ -37,12 +36,10 @@
class ClaimHtmlGeneratorTest extends \PHPUnit_Framework_TestCase {
/**
- * @return DispatchingSnakFormatter
+ * @return SnakFormatter
*/
protected function getSnakFormatterMock() {
- $snakFormatter = $this->getMockBuilder(
'Wikibase\Lib\DispatchingSnakFormatter' )
- ->disableOriginalConstructor()
- ->getMock();
+ $snakFormatter = $this->getMock( 'Wikibase\Lib\SnakFormatter' );
$snakFormatter->expects( $this->any() )
->method( 'formatSnak' )
diff --git a/repo/tests/phpunit/includes/View/SnakHtmlGeneratorTest.php
b/repo/tests/phpunit/includes/View/SnakHtmlGeneratorTest.php
index 5a533d8..91648d6 100644
--- a/repo/tests/phpunit/includes/View/SnakHtmlGeneratorTest.php
+++ b/repo/tests/phpunit/includes/View/SnakHtmlGeneratorTest.php
@@ -9,7 +9,6 @@
use Wikibase\DataModel\Snak\PropertySomeValueSnak;
use Wikibase\DataModel\Snak\PropertyValueSnak;
use Wikibase\DataModel\Snak\Snak;
-use Wikibase\Lib\DispatchingSnakFormatter;
use Wikibase\Lib\EntityIdFormatter;
use Wikibase\Lib\SnakFormatter;
use Wikibase\Lib\Store\EntityTitleLookup;
@@ -88,12 +87,10 @@
}
/**
- * @return DispatchingSnakFormatter
+ * @return SnakFormatter
*/
protected function getSnakFormatterMock() {
- $snakFormatter = $this->getMockBuilder(
'Wikibase\Lib\DispatchingSnakFormatter' )
- ->disableOriginalConstructor()
- ->getMock();
+ $snakFormatter = $this->getMock( 'Wikibase\Lib\SnakFormatter' );
$snakFormatter->expects( $this->any() )
->method( 'formatSnak' )
--
To view, visit https://gerrit.wikimedia.org/r/180154
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f81844112e2b0f72402628f8c432f2f38fc2881
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <adrian.l...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
