[MediaWiki-commits] [Gerrit] Tweak styling of collapsed infoboxes. - change (mediawiki...MobileApp)

[BearND (Code Review)]

BearND has submitted this change and it was merged.

Change subject: Tweak styling of collapsed infoboxes.
......................................................................


Tweak styling of collapsed infoboxes.

Also removed some unused stuff.

Change-Id: Id8b883fb4947be45dc65d5f8c81fa83591b00a52
---
M images/table_collapse.png
M images/table_expand.png
M styles/android.less
M styles/night.less
M styles/tables.less
5 files changed, 12 insertions(+), 28 deletions(-)

Approvals:
  BearND: Verified; Looks good to me, approved



diff --git a/images/table_collapse.png b/images/table_collapse.png
index cdf731a..86f59ee 100644
--- a/images/table_collapse.png
+++ b/images/table_collapse.png
Binary files differ
diff --git a/images/table_expand.png b/images/table_expand.png
index cdda8ea..f94b525 100644
--- a/images/table_expand.png
+++ b/images/table_expand.png
Binary files differ
diff --git a/styles/android.less b/styles/android.less
index 431f6e6..cc027a5 100644
--- a/styles/android.less
+++ b/styles/android.less
@@ -1,7 +1,3 @@
-body {
-       padding-top: 48px;
-}
-
 /* Loading animation in pure CSS
    Thanks to http://dabblet.com/gist/7708654 */
 .loading {
@@ -24,14 +20,4 @@
     margin: 8px auto;
     height: 24px;
     width: 24px;
-}
-
-/* Last updated info */
-#attribution {
-  border-top: 1px solid #ccc;
-  padding: 8px;
-  text-align: center;
-  color: #888;
-  font-size: 80%;
-  clear: both;
 }
diff --git a/styles/night.less b/styles/night.less
index 49c603c..09f64ba 100644
--- a/styles/night.less
+++ b/styles/night.less
@@ -28,8 +28,11 @@
     background: #000;
 }
 
+.app_table_container {
+    box-shadow: 0px 1px 4px 4px rgba(128,128,128,.12);
+}
+
 .app_table_collapsed_container {
-    border: solid 1px #505050;
     background-color: #202020;
 }
 
@@ -38,6 +41,5 @@
 }
 
 .app_table_collapsed_bottom {
-    border: solid 1px #505050;
     background-color: #202020;
 }
diff --git a/styles/tables.less b/styles/tables.less
index 17ada49..21de7a0 100644
--- a/styles/tables.less
+++ b/styles/tables.less
@@ -1,34 +1,33 @@
 
 .app_table_container {
-    display: inline;
     width: 100%;
+    margin-top: 14px;
+    margin-bottom: 14px;
+    border-radius: 2px 2px 2px 2px;
+    box-shadow: 0px 2px 2px 0px rgba(0,0,0,0.12), 0px 1px 5px 0px 
rgba(0,0,0,0.24);
 }
 
 .app_table_collapsed_container {
     width: 100%;
-    margin-top: 10px;
     padding-left: 12px;
     padding-right: 48px;
     padding-top: 12px;
     padding-bottom: 12px;
-    line-height: 100%;
-    border: solid 1px #b0b0b0;
+    line-height: 120%;
     background-color: #f0f0f0;
     background-repeat: no-repeat;
     background-position: 95% 50%;
-    background-size: 20px 20px;
+    background-size: 16px 16px;
 }
 
 .app_table_collapsed_open {
     border-radius: 2px 2px 2px 2px;
-    margin-bottom: 10px;
     /* @embed */
     background-image: url( '../images/table_expand.png' );
 }
 
 .app_table_collapse_close {
     border-radius: 2px 2px 0px 0px;
-    margin-bottom: 0px;
 }
 
 .app_table_collapse_icon {
@@ -43,17 +42,14 @@
 .app_table_collapsed_bottom {
     width: 100%;
     color: #808080;
-    margin-top: 0px;
-    margin-bottom: 10px;
     padding-left: 12px;
     padding-right: 48px;
     padding-top: 12px;
     padding-bottom: 12px;
-    line-height: 100%;
-    border: solid 1px #b0b0b0;
+    line-height: 120%;
     border-radius: 0px 0px 2px 2px;
     background-color: #f0f0f0;
     background-repeat: no-repeat;
     background-position: 95% 50%;
-    background-size: 20px 20px;
+    background-size: 16px 16px;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/179919
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id8b883fb4947be45dc65d5f8c81fa83591b00a52
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileApp
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits