Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/180737
Change subject: getDirectionality may return undefined ...................................................................... getDirectionality may return undefined Either this or change the doc to @return {string|undefined}. Change-Id: I043376d0676d82d9052ee98478024dbe9e6f3a5a --- M repo/resources/jquery/jquery.util.getDirectionality.js 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/37/180737/1 diff --git a/repo/resources/jquery/jquery.util.getDirectionality.js b/repo/resources/jquery/jquery.util.getDirectionality.js index 6a3a746..d2edc26 100644 --- a/repo/resources/jquery/jquery.util.getDirectionality.js +++ b/repo/resources/jquery/jquery.util.getDirectionality.js @@ -15,7 +15,7 @@ */ $.util.getDirectionality = function( languageCode ) { var dir = $.uls && $.uls.data ? $.uls.data.getDir( languageCode ) : $( 'html' ).prop( 'dir' ); - return dir !== '' ? dir : 'auto'; + return dir ? dir : 'auto'; }; }( jQuery ) ); -- To view, visit https://gerrit.wikimedia.org/r/180737 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I043376d0676d82d9052ee98478024dbe9e6f3a5a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits