Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/180872
Change subject: Re-add null check in SpecialSetSiteLink
......................................................................
Re-add null check in SpecialSetSiteLink
Otherwise, i get:
The site id "" is unknown. Please use an existing site id, such as "enwiki".
whenever i visit url like Special:SetSiteLink/Q139. The null check
should probably also go first, since the valid check is more 'expensive'.
Change-Id: Ic78b81ae90fca7b0acebe0b658fcfb87586b0c09
---
M repo/includes/specials/SpecialSetSiteLink.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/72/180872/1
diff --git a/repo/includes/specials/SpecialSetSiteLink.php
b/repo/includes/specials/SpecialSetSiteLink.php
index 35402cf..65fb6b0 100644
--- a/repo/includes/specials/SpecialSetSiteLink.php
+++ b/repo/includes/specials/SpecialSetSiteLink.php
@@ -132,7 +132,7 @@
$this->site = null;
}
- if ( !$this->isValidSiteId( $this->site ) ) {
+ if ( $this->site !== null && !$this->isValidSiteId( $this->site
) ) {
$this->showErrorHTML( $this->msg(
'wikibase-setsitelink-invalid-site', $this->site )->parse() );
}
--
To view, visit https://gerrit.wikimedia.org/r/180872
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic78b81ae90fca7b0acebe0b658fcfb87586b0c09
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: wmf/1.25wmf12c
Gerrit-Owner: Aude <aude.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
