jenkins-bot has submitted this change and it was merged. Change subject: make-release: Use "as" when catching exceptions ......................................................................
make-release: Use "as" when catching exceptions "as" is valid python2.7, but necessary in python3 Change-Id: Ida914e11d906d6c87e0b00726f824c97d04351a0 --- M make-release/make-release.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yuvipanda: Looks good to me, approved jenkins-bot: Verified diff --git a/make-release/make-release.py b/make-release/make-release.py index 906a081..ca3bddd 100755 --- a/make-release/make-release.py +++ b/make-release/make-release.py @@ -631,7 +631,7 @@ try: proc = subprocess.Popen([ 'gpg', '--detach-sign', buildDir + '/' + fileName]) - except OSError, e: + except OSError as e: logging.error("gpg failed, does it exist? Skip with --dont-sign.") logging.error("Error %s: %s", e.errno, e.strerror) sys.exit(1) -- To view, visit https://gerrit.wikimedia.org/r/181041 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida914e11d906d6c87e0b00726f824c97d04351a0 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/tools/release Gerrit-Branch: master Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: Yuvipanda <yuvipa...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits