Jhernandez has uploaded a new change for review. https://gerrit.wikimedia.org/r/181063
Change subject: Fix MW_INSTALL_PATH to default to local installation ...................................................................... Fix MW_INSTALL_PATH to default to local installation Which is usually ../../ if executed in the local file system. This was causing problems when running make jsduck in the pre-review script. Locally grunt docs and MW_INSTALL_PATH=../../ make jsduck work fine. This is the reason why 26 errors show on the docs warnings with make jsduck but only a couple (or none with the previous patch) are shown if executed with grunt docs. This may be annoying if somebody works from inside vagrant? Change-Id: I4fe8f9fb36dcf8e3bb3d1530cf6aa1eef8ddbd4b --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/63/181063/1 diff --git a/Makefile b/Makefile index 07b76de..85a9097 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,4 @@ -MW_INSTALL_PATH ?= /vagrant/mediawiki/ +MW_INSTALL_PATH ?= ../../ MEDIAWIKI_LOAD_URL ?= http://localhost:8080/w/load.php # From https://gist.github.com/prwhite/8168133 -- To view, visit https://gerrit.wikimedia.org/r/181063 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4fe8f9fb36dcf8e3bb3d1530cf6aa1eef8ddbd4b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jhernandez <jhernan...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
