jenkins-bot has submitted this change and it was merged. Change subject: Correct positioning of the selector dialog for RTL ......................................................................
Correct positioning of the selector dialog for RTL Bug: T85128 Change-Id: Icb62ed9352f72c282221fa0732a402a77a1c6aa7 --- M modules/source/ext.cx.source.selector.js 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Santhosh: Looks good to me, approved Jsahleen: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/source/ext.cx.source.selector.js b/modules/source/ext.cx.source.selector.js index d4b5a9a..b191155 100644 --- a/modules/source/ext.cx.source.selector.js +++ b/modules/source/ext.cx.source.selector.js @@ -591,9 +591,7 @@ * over the rest of the content on the page. */ CXSourceSelector.prototype.showAsDialog = function () { - var top, left, dir; - - dir = $( 'html' ).prop( 'dir' ); + var top, left; if ( this.options.top ) { top = this.options.top; @@ -606,10 +604,6 @@ left = this.options.left; } else { left = ( $( window ).width() - this.$dialog.width() ) / 2; - } - - if ( dir === 'rtl' ) { - left = left - this.$dialog.width(); } this.$dialog.css( { -- To view, visit https://gerrit.wikimedia.org/r/181390 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb62ed9352f72c282221fa0732a402a77a1c6aa7 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Amire80 <amir.ahar...@mail.huji.ac.il> Gerrit-Reviewer: Jsahleen <jsahl...@wikimedia.org> Gerrit-Reviewer: Pginer <pgi...@wikimedia.org> Gerrit-Reviewer: Santhosh <santhosh.thottin...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits