Brion VIBBER has uploaded a new change for review.
https://gerrit.wikimedia.org/r/181608
Change subject: work around kerbooooooooooom in page loading if HTML sections
used
......................................................................
work around kerbooooooooooom in page loading if HTML sections used
HTML sections return a 'fromtitle' of 'false' which .... maybe ...
indicates they shouldn't be editable?
This tweak treats them as nil which is not ideal but gets things running.
Change-Id: Idcdaf6ff4cb933fd3d4beef864cc7faa12c53e53
---
M MediaWikiKit/MediaWikiKit/MWKSection.m
M MediaWikiKit/MediaWikiKit/MWKSiteDataObject.m
M wikipedia/Networking/Fetchers/ArticleFetcher.m
3 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia
refs/changes/08/181608/1
diff --git a/MediaWikiKit/MediaWikiKit/MWKSection.m
b/MediaWikiKit/MediaWikiKit/MWKSection.m
index fcddd6f..11727a1 100644
--- a/MediaWikiKit/MediaWikiKit/MWKSection.m
+++ b/MediaWikiKit/MediaWikiKit/MWKSection.m
@@ -55,7 +55,7 @@
dict[@"index"] = self.index;
}
if (self.fromtitle) {
- dict[@"fromtitle"] = [self.fromtitle prefixedText];
+ dict[@"fromtitle"] = self.fromtitle.prefixedText;
}
if (self.anchor) {
dict[@"anchor"] = self.anchor;
diff --git a/MediaWikiKit/MediaWikiKit/MWKSiteDataObject.m
b/MediaWikiKit/MediaWikiKit/MWKSiteDataObject.m
index 6b607b5..46b910b 100644
--- a/MediaWikiKit/MediaWikiKit/MWKSiteDataObject.m
+++ b/MediaWikiKit/MediaWikiKit/MWKSiteDataObject.m
@@ -23,6 +23,10 @@
- (MWKTitle *)optionalTitle:(NSString *)key dict:(NSDictionary *)dict
{
+ if ([dict[key] isKindOfClass:[NSNumber class]] && ![dict[key] boolValue]) {
+ // false sometimes happens. Thanks PHP and weak typing!
+ return nil;
+ }
NSString *str = [self optionalString:key dict:dict];
if (str == nil) {
return nil;
diff --git a/wikipedia/Networking/Fetchers/ArticleFetcher.m
b/wikipedia/Networking/Fetchers/ArticleFetcher.m
index 8e05106..615422e 100644
--- a/wikipedia/Networking/Fetchers/ArticleFetcher.m
+++ b/wikipedia/Networking/Fetchers/ArticleFetcher.m
@@ -94,6 +94,7 @@
[self.article save];
}
@catch (NSException *e) {
+ NSLog(@"%@", e);
NSError *err = [NSError errorWithDomain:@"ArticleFetcher" code:666
userInfo:@{@"exception": e}];
[self finishWithError: err
fetchedData: nil];
--
To view, visit https://gerrit.wikimedia.org/r/181608
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcdaf6ff4cb933fd3d4beef864cc7faa12c53e53
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
