jenkins-bot has submitted this change and it was merged. Change subject: Restore main menu animations ......................................................................
Restore main menu animations Bug: T85253 Change-Id: I7dcd564250aadd6408c45fa911c2b9f1fe60cfe4 --- M less/mainmenu.less 1 file changed, 30 insertions(+), 14 deletions(-) Approvals: Bmansurov: Verified; Looks good to me, approved jenkins-bot: Verified diff --git a/less/mainmenu.less b/less/mainmenu.less index f1e2a58..1efa3a4 100644 --- a/less/mainmenu.less +++ b/less/mainmenu.less @@ -257,10 +257,11 @@ // animated version // FIXME: doesn't work in Firefox due to https://bugzilla.mozilla.org/show_bug.cgi?id=625289 // do we want to work around it? +@duration: .25s; +@easing: ease-out; +// FIXME: Cleanup animation css .animations { - @duration: .25s; - @easing: ease-out; #mw-mf-page-center { min-height: 100%; @@ -279,6 +280,7 @@ .transition(visibility 0s @duration); } + // FIXME: Make animations a conditional class on the drawer itself .notifications-overlay.navigation-drawer { display: block; @@ -290,15 +292,21 @@ .transform(translate3d(0, 0, 0)); } } +} - .navigation-enabled { + +.navigation-enabled { + + .animations { .position-fixed, #mw-mf-page-center { .transition-transform(@duration @easing); } } +} - .primary-navigation-enabled { +.primary-navigation-enabled { + .animations { .position-fixed, #mw-mf-page-center { // override non-animated version @@ -313,8 +321,10 @@ .transition(none); } } +} - .secondary-navigation-enabled { +.secondary-navigation-enabled { + .animations { #mw-mf-page-center { // override non-animated version left: 0 !important; @@ -322,25 +332,31 @@ width: 100%; } } +} - .rtl { - .notifications-overlay.navigation-drawer { - // +2% to accommodate for the border/box-shadow - .transform(translate3d(-102%, 0, 0)); +.rtl { + // FIXME: Make animations a conditional class on the drawer itself + .animations .notifications-overlay.navigation-drawer { + // +2% to accommodate for the border/box-shadow + .transform(translate3d(-102%, 0, 0)); - &.visible { - .transform(translate3d(0, 0, 0)); - } + &.visible { + .transform(translate3d(0, 0, 0)); } + } - &.primary-navigation-enabled { + &.primary-navigation-enabled { + .animations { + .position-fixed, #mw-mf-page-center { .transform(translate3d(-@menuWidth, 0, 0)); } } + } - &.secondary-navigation-enabled { + &.secondary-navigation-enabled { + .animations { #mw-mf-page-center { .transform(translate3d(@rightDrawerWidth, 0, 0)); } -- To view, visit https://gerrit.wikimedia.org/r/181707 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7dcd564250aadd6408c45fa911c2b9f1fe60cfe4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: Bmansurov <bmansu...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
