[MediaWiki-commits] [Gerrit] add to Special Page Group, minor cleanup - change (mediawiki...NewestPages)

[tosfos (Code Review)]

tosfos has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/181781

Change subject: add to Special Page Group, minor cleanup
......................................................................

add to Special Page Group, minor cleanup

Change-Id: Iac21ff841e674fcbdb861c03422a5189a9481d32
---
M NewestPages.page.php
M NewestPages.php
2 files changed, 16 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/NewestPages 
refs/changes/81/181781/1

diff --git a/NewestPages.page.php b/NewestPages.page.php
index 300f3d6..a060c5a 100644
--- a/NewestPages.page.php
+++ b/NewestPages.page.php
@@ -55,7 +55,8 @@
                        $this->setHeaders();
                        $limit = $wgLang->formatNum( $this->limit );
                        if( $this->namespace > 0 ) {
-                               $wgOut->addWikiMsg( 'newestpages-ns-header', 
$limit, $wgContLang->getFormattedNsText( $this->namespace ) );
+                               $wgOut->addWikiMsg( 'newestpages-ns-header', 
$limit,
+                                       $wgContLang->getFormattedNsText( 
$this->namespace ) );
                        } else {
                                $wgOut->addWikiMsg( 'newestpages-header', 
$limit );
                        }
@@ -130,9 +131,10 @@
                        $link = $row->page_is_redirect
                                        ? '<span class="allpagesredirect">' . 
Linker::makeKnownLinkObj( $title ) . '</span>'
                                        : Linker::makeKnownLinkObj( $title );
-                       return( "<li>{$link}</li>\n" );
+                       return "<li>{$link}</li>\n";
                } else {
-                       return( "<!-- Invalid title " . htmlspecialchars( 
$row->page_title ) . " in namespace " . htmlspecialchars( $row->page_namespace 
) . " -->\n" );
+                       return "<!-- Invalid title " . htmlspecialchars( 
$row->page_title ) .
+                               " in namespace " . htmlspecialchars( 
$row->page_namespace ) . " -->\n";
                }
        }
 
@@ -147,7 +149,7 @@
                                $links[] = (string)$limit;
                        }
                }
-               return( wfMsgHtml( 'newestpages-limitlinks', $wgLang->pipeList( 
$links ) ) );
+               return wfMsgHtml( 'newestpages-limitlinks', $wgLang->pipeList( 
$links ) );
        }
 
        function makeRedirectToggle() {
@@ -170,7 +172,8 @@
 
        function makeNamespaceForm() {
                $self = $this->getTitle();
-               $form  = Xml::openElement( 'form', array( 'method' => 'post', 
'action' => $self->getLocalUrl() ) );
+               $form = Xml::openElement(
+                               'form', array( 'method' => 'post', 'action' => 
$self->getLocalUrl() ) );
                $form .= Xml::label( wfMsg( 'newestpages-namespace' ), 
'namespace' ) . '&#160;';
                $form .= Html::namespaceSelector( array(
                        'selected' => $this->namespace,
@@ -186,4 +189,8 @@
                $form .= Xml::submitButton( wfMsg( 'newestpages-submit' ) ) . 
'</form>';
                return $form;
        }
+
+       protected function getGroupName() {
+               return 'changes';
+       }
 }
diff --git a/NewestPages.php b/NewestPages.php
index cf0ccfc..ccff356 100644
--- a/NewestPages.php
+++ b/NewestPages.php
@@ -1,6 +1,5 @@
 <?php
-if ( ! defined( 'MEDIAWIKI' ) )
-    die();
+if ( !defined( 'MEDIAWIKI' ) ) die();
 
 /**
  * Special page to show the last X pages added to the wiki
@@ -24,9 +23,8 @@
 
 $wgNewestPagesLimit = 50;
 
-$dir = dirname(__FILE__) . '/';
 $wgMessagesDirs['NewestPages'] = __DIR__ . '/i18n';
-$wgExtensionMessagesFiles['NewestPages'] = $dir . 'NewestPages.i18n.php';
-$wgExtensionMessagesFiles['NewestPagesAlias'] = $dir . 'NewestPages.alias.php';
-$wgAutoloadClasses['NewestPages'] = $dir . 'NewestPages.page.php';
+$wgExtensionMessagesFiles['NewestPages'] = __DIR__ . '/NewestPages.i18n.php';
+$wgExtensionMessagesFiles['NewestPagesAlias'] = __DIR__ . 
'/NewestPages.alias.php';
+$wgAutoloadClasses['NewestPages'] = __DIR__ . '/NewestPages.page.php';
 $wgSpecialPages['NewestPages'] = 'NewestPages';

-- 
To view, visit https://gerrit.wikimedia.org/r/181781
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac21ff841e674fcbdb861c03422a5189a9481d32
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NewestPages
Gerrit-Branch: master
Gerrit-Owner: tosfos <tos...@yahoo.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits