Gerrit Patch Uploader has uploaded a new change for review. https://gerrit.wikimedia.org/r/181970
Change subject: Fix module dependencies ...................................................................... Fix module dependencies * Add 'jquery.mwExtension' where $.escapeRE() is used. * Remove double entries. * Add comma after last entry. * Alphabetic sort. Change-Id: I5111a3d3fa0cca6f1b1342385545aa7a8a1e780d --- M MoodBar.php 1 file changed, 10 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MoodBar refs/changes/70/181970/1 diff --git a/MoodBar.php b/MoodBar.php index 6cc167c..3fe4e0d 100644 --- a/MoodBar.php +++ b/MoodBar.php @@ -106,9 +106,9 @@ ), 'position' => 'bottom', 'dependencies' => array( - 'jquery.cookie', 'jquery.client', - 'mediawiki.util' + 'jquery.cookie', + 'mediawiki.util', ), ); @@ -120,8 +120,9 @@ ), 'position' => 'bottom', 'dependencies' => array( - 'jquery.cookie', 'ext.moodBar.init', + 'jquery.cookie', + 'jquery.mwExtension', // for $.escapeRE() ), ); @@ -190,13 +191,13 @@ 'moodbar-fbd-link-title', ), 'dependencies' => array( - 'mediawiki.util', - 'mediawiki.jqueryMsg', // for PLURAL support 'ext.moodBar.init', // just in case 'jquery.localize', - 'jquery.NobleCount', 'jquery.moodBar', - 'mediawiki.jqueryMsg', + 'jquery.mwExtension', // for $.escapeRE() + 'jquery.NobleCount', + 'mediawiki.jqueryMsg', // for PLURAL support + 'mediawiki.util', ), 'position' => 'bottom', ); @@ -204,10 +205,10 @@ $wgResourceModules['ext.moodBar.dashboard'] = $mbResourceTemplate + array( 'scripts' => 'ext.moodBar.dashboard/ext.moodBar.dashboard.js', 'dependencies' => array( + 'jquery.elastic', + 'jquery.NobleCount', 'mediawiki.util', 'user.tokens', - 'jquery.NobleCount', - 'jquery.elastic' ), 'messages' => array( 'moodbar-feedback-nomore', -- To view, visit https://gerrit.wikimedia.org/r/181970 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5111a3d3fa0cca6f1b1342385545aa7a8a1e780d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MoodBar Gerrit-Branch: master Gerrit-Owner: Gerrit Patch Uploader <gerritpatchuploa...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits