Umherirrender has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/182083

Change subject: Escape word-separator and parenthesis in preferences
......................................................................

Escape word-separator and parenthesis in preferences

When building a link for email the messages word-separator and
parenthesis are not escaped.

Change-Id: Idbbec4dbdca1d0a0b598df2015c74961445e6d83
---
M includes/Preferences.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/83/182083/1

diff --git a/includes/Preferences.php b/includes/Preferences.php
index aca6dcb..e0cfa77 100644
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
@@ -450,8 +450,8 @@
                                                array( 'returnto' => 
SpecialPage::getTitleFor( 'Preferences' )->getPrefixedText() ) );
 
                                        $emailAddress .= $emailAddress == '' ? 
$link : (
-                                               $context->msg( 'word-separator' 
)->plain()
-                                               . $context->msg( 'parentheses' 
)->rawParams( $link )->plain()
+                                               $context->msg( 'word-separator' 
)->escaped()
+                                               . $context->msg( 'parentheses' 
)->rawParams( $link )->escaped()
                                        );
                                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/182083
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idbbec4dbdca1d0a0b598df2015c74961445e6d83
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to